linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

Hi all,

Today's linux-next merge of the gpio-brgl tree got a conflict in:

  drivers/gpio/gpiolib.h

between commit:

  7765ffed533d ("gpiolib: use a single SRCU struct for all GPIO descriptors")

from the gpio-brgl-fixes tree and commit:

  8a7a61032587 ("gpiolib: Get rid of never false gpio_is_valid() calls")

from the gpio-brgl tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpio/gpiolib.h
index 8e0e211ebf08,7f94580efdbc..000000000000
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@@ -62,8 -61,7 +62,8 @@@ struct gpio_device 
  	struct module		*owner;
  	struct gpio_chip __rcu	*chip;
  	struct gpio_desc	*descs;
 +	struct srcu_struct	desc_srcu;
- 	int			base;
+ 	unsigned int		base;
  	u16			ngpio;
  	bool			can_sleep;
  	const char		*label;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Bartosz Golaszewski]

On Fri, 10 May 2024 at 07:32, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Today's linux-next merge of the gpio-brgl tree got a conflict in:
>
>   drivers/gpio/gpiolib.h
>
> between commit:
>
>   7765ffed533d ("gpiolib: use a single SRCU struct for all GPIO descriptors")
>
> from the gpio-brgl-fixes tree and commit:
>
>   8a7a61032587 ("gpiolib: Get rid of never false gpio_is_valid() calls")
>
> from the gpio-brgl tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc drivers/gpio/gpiolib.h
> index 8e0e211ebf08,7f94580efdbc..000000000000
> --- a/drivers/gpio/gpiolib.h
> +++ b/drivers/gpio/gpiolib.h
> @@@ -62,8 -61,7 +62,8 @@@ struct gpio_device
>         struct module           *owner;
>         struct gpio_chip __rcu  *chip;
>         struct gpio_desc        *descs;
>  +      struct srcu_struct      desc_srcu;
> -       int                     base;
> +       unsigned int            base;
>         u16                     ngpio;
>         bool                    can_sleep;
>         const char              *label;

Thanks! I will send the fixes upstream today and then pull v6.9 into
my tree before the merge window PR to fix this conflict.

Bart

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Hi Bartosz,

On Fri, 10 May 2024 08:33:37 +0200 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> wrote:
>
> Thanks! I will send the fixes upstream today and then pull v6.9 into
> my tree before the merge window PR to fix this conflict.

Or you could just merge your for-current branch into your for-next
branch and avoid possible issues with all the rest of v6.9 ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

Hi Stephen,

On Fri, 10 May 2024 17:08:27 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Bartosz,
> 
> On Fri, 10 May 2024 08:33:37 +0200 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> wrote:
> >
> > Thanks! I will send the fixes upstream today and then pull v6.9 into
> > my tree before the merge window PR to fix this conflict.  
> 
> Or you could just merge your for-current branch into your for-next
> branch and avoid possible issues with all the rest of v6.9 ...

Or, since it is a pretty simple conflict, just do not merge and just
mention the conflict to Linus in your merge window PR.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Andy Shevchenko]

On Fri, May 10, 2024 at 05:10:49PM +1000, Stephen Rothwell wrote:
> On Fri, 10 May 2024 17:08:27 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Fri, 10 May 2024 08:33:37 +0200 Bartosz Golaszewski <bartosz.golaszewski@linaro.org> wrote:
> > >
> > > Thanks! I will send the fixes upstream today and then pull v6.9 into
> > > my tree before the merge window PR to fix this conflict.  
> > 
> > Or you could just merge your for-current branch into your for-next
> > branch and avoid possible issues with all the rest of v6.9 ...
> 
> Or, since it is a pretty simple conflict, just do not merge and just
> mention the conflict to Linus in your merge window PR.

I also would go the latest suggestion.

-- 
With Best Regards,
Andy Shevchenko

linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 2258 bytes --]

Hi all,

Today's linux-next merge of the gpio-brgl tree got a conflict in:

  Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml

between commit:

  6b5ef8c88854b ("dt-bindings: gpio: fix microchip #interrupt-cells")

from the gpio-brgl-fixes tree and commit:

  ececb46fc9477 ("dt-bindings: gpio: fix microchip,mpfs-gpio interrupt documentation")

from the gpio-brgl tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

diff --cc Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
index f42c54653d521,6a0c5341d8a42..0000000000000
--- a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
@@@ -82,18 -90,19 +90,19 @@@ examples
          compatible = "microchip,mpfs-gpio";
          reg = <0x20122000 0x1000>;
          clocks = <&clkcfg 25>;
-         interrupt-parent = <&plic>;
+         interrupt-parent = <&irqmux>;
          gpio-controller;
          #gpio-cells = <2>;
+         ngpios = <32>;
          interrupt-controller;
 -        #interrupt-cells = <1>;
 +        #interrupt-cells = <2>;
-         interrupts = <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>,
-                      <53>, <53>, <53>, <53>;
+         interrupts = <64>, <65>, <66>, <67>,
+                      <68>, <69>, <70>, <71>,
+                      <72>, <73>, <74>, <75>,
+                      <76>, <77>, <78>, <79>,
+                      <80>, <81>, <82>, <83>,
+                      <84>, <85>, <86>, <87>,
+                      <88>, <89>, <90>, <91>,
+                      <92>, <93>, <94>, <95>;
      };
  ...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Hi all,

Today's linux-next merge of the gpio-brgl tree got a conflict in:

  drivers/gpio/gpiolib.c

between commit:

  0102fbf52b93 ("gpiolib: don't check the retval of get_direction() when registering a chip")

from the gpio-brgl-fixes tree and commit:

  9becde08f1bc ("gpiolib: don't use gpiochip_get_direction() when registering a chip")

from the gpio-brgl tree.

I fixed it up (I used the latter as the conflict was just in a comment)
and can carry the fix as necessary. This is now fixed as far as linux-next
is concerned, but any non trivial conflicts should be mentioned to your
upstream maintainer when your tree is submitted for merging.  You may
also want to consider cooperating with the maintainer of the conflicting
tree to minimise any particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Bartosz Golaszewski]

On Fri, Mar 14, 2025 at 6:06 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Today's linux-next merge of the gpio-brgl tree got a conflict in:
>
>   drivers/gpio/gpiolib.c
>
> between commit:
>
>   0102fbf52b93 ("gpiolib: don't check the retval of get_direction() when registering a chip")
>
> from the gpio-brgl-fixes tree and commit:
>
>   9becde08f1bc ("gpiolib: don't use gpiochip_get_direction() when registering a chip")
>
> from the gpio-brgl tree.
>
> I fixed it up (I used the latter as the conflict was just in a comment)
> and can carry the fix as necessary. This is now fixed as far as linux-next
> is concerned, but any non trivial conflicts should be mentioned to your
> upstream maintainer when your tree is submitted for merging.  You may
> also want to consider cooperating with the maintainer of the conflicting
> tree to minimise any particularly complex conflicts.
>

Thanks,

I will pull v6.14-rc7 into my for-next branch once it's tagged and
resolve the conflict before the merge window.

Bartosz

linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3130 bytes --]

Hi all,

Today's linux-next merge of the gpio-brgl tree got a conflict in:

  drivers/gpio/gpiolib.c

between commit:

  64407f4b5807 ("gpiolib: Fix Oops in gpiod_direction_input_nonotify()")

from the gpio-brgl-fixes tree and commit:

  e623c4303ed1 ("gpiolib: sanitize the return value of gpio_chip::get_direction()")

from the gpio-brgl tree.

I fixed it up (I think - see below) and can carry the fix as
necessary. This is now fixed as far as linux-next is concerned, but any
non trivial conflicts should be mentioned to your upstream maintainer
when your tree is submitted for merging.  You may also want to consider
cooperating with the maintainer of the conflicting tree to minimise any
particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpio/gpiolib.c
index 8741600af7ef,d0108cf2ee0b..000000000000
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@@ -2737,15 -2804,14 +2804,14 @@@ int gpiod_direction_input_nonotify(stru
  	 * assume we are in input mode after this.
  	 */
  	if (guard.gc->direction_input) {
- 		ret = guard.gc->direction_input(guard.gc,
- 						gpio_chip_hwgpio(desc));
+ 		ret = gpiochip_direction_input(guard.gc,
+ 					       gpio_chip_hwgpio(desc));
  	} else if (guard.gc->get_direction) {
- 		dir = guard.gc->get_direction(guard.gc,
- 					      gpio_chip_hwgpio(desc));
 -		ret = gpiochip_get_direction(guard.gc, gpio_chip_hwgpio(desc));
 -		if (ret < 0)
 -			return ret;
++		dir = gpiochip_get_direction(guard.gc, gpio_chip_hwgpio(desc));
 +		if (dir < 0)
 +			return dir;
  
 -		if (ret != GPIO_LINE_DIRECTION_IN) {
 +		if (dir != GPIO_LINE_DIRECTION_IN) {
  			gpiod_warn(desc,
  				   "%s: missing direction_input() operation and line is output\n",
  				    __func__);
@@@ -2762,9 -2828,30 +2828,30 @@@
  	return ret;
  }
  
+ static int gpiochip_set(struct gpio_chip *gc, unsigned int offset, int value)
+ {
+ 	int ret;
+ 
+ 	lockdep_assert_held(&gc->gpiodev->srcu);
+ 
+ 	if (WARN_ON(unlikely(!gc->set && !gc->set_rv)))
+ 		return -EOPNOTSUPP;
+ 
+ 	if (gc->set_rv) {
+ 		ret = gc->set_rv(gc, offset, value);
+ 		if (ret > 0)
+ 			ret = -EBADE;
+ 
+ 		return ret;
+ 	}
+ 
+ 	gc->set(gc, offset, value);
+ 	return 0;
+ }
+ 
  static int gpiod_direction_output_raw_commit(struct gpio_desc *desc, int value)
  {
 -	int val = !!value, ret = 0;
 +	int val = !!value, ret = 0, dir;
  
  	CLASS(gpio_chip_guard, guard)(desc);
  	if (!guard.gc)
@@@ -2788,12 -2875,12 +2875,12 @@@
  	} else {
  		/* Check that we are in output mode if we can */
  		if (guard.gc->get_direction) {
- 			dir = guard.gc->get_direction(guard.gc,
- 						      gpio_chip_hwgpio(desc));
 -			ret = gpiochip_get_direction(guard.gc,
++			dir = gpiochip_get_direction(guard.gc,
+ 						     gpio_chip_hwgpio(desc));
 -			if (ret < 0)
 -				return ret;
 +			if (dir < 0)
 +				return dir;
  
 -			if (ret != GPIO_LINE_DIRECTION_OUT) {
 +			if (dir != GPIO_LINE_DIRECTION_OUT) {
  				gpiod_warn(desc,
  					   "%s: missing direction_output() operation\n",
  					   __func__);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Bartosz Golaszewski]

On Mon, 3 Mar 2025 at 06:57, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Today's linux-next merge of the gpio-brgl tree got a conflict in:
>
>   drivers/gpio/gpiolib.c
>
> between commit:
>
>   64407f4b5807 ("gpiolib: Fix Oops in gpiod_direction_input_nonotify()")
>
> from the gpio-brgl-fixes tree and commit:
>
>   e623c4303ed1 ("gpiolib: sanitize the return value of gpio_chip::get_direction()")
>
> from the gpio-brgl tree.
>
> I fixed it up (I think - see below) and can carry the fix as
> necessary. This is now fixed as far as linux-next is concerned, but any
> non trivial conflicts should be mentioned to your upstream maintainer
> when your tree is submitted for merging.  You may also want to consider
> cooperating with the maintainer of the conflicting tree to minimise any
> particularly complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>

Hi Stephen!

Thanks, I pulled in v6.14-rc5 into my for-next branch and fixed the
conflicts there, next should be fine tomorrow.

Bartosz

linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

Hi all,

Today's linux-next merge of the gpio-brgl tree got a conflict in:

  drivers/gpio/gpio-vf610.c

between commit:

  fc363413ef8e ("gpio: vf610: set value before the direction to avoid a glitch")

from the gpio-brgl-fixes tree and commit:

  b57587f11f81 ("gpio: vf610: simplify code by dropping data check")

from the gpio-brgl tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpio/gpio-vf610.c
index 656d6b1dddb5,a89ae84a1fa0..000000000000
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@@ -126,9 -140,7 +140,9 @@@ static int vf610_gpio_direction_output(
  	unsigned long mask = BIT(gpio);
  	u32 val;
  
 +	vf610_gpio_set(chip, gpio, value);
 +
- 	if (port->sdata && port->sdata->have_paddr) {
+ 	if (port->sdata->have_paddr) {
  		val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
  		val |= mask;
  		vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Bartosz Golaszewski]

On Thu, 19 Oct 2023 at 07:06, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Today's linux-next merge of the gpio-brgl tree got a conflict in:
>
>   drivers/gpio/gpio-vf610.c
>
> between commit:
>
>   fc363413ef8e ("gpio: vf610: set value before the direction to avoid a glitch")
>
> from the gpio-brgl-fixes tree and commit:
>
>   b57587f11f81 ("gpio: vf610: simplify code by dropping data check")
>
> from the gpio-brgl tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc drivers/gpio/gpio-vf610.c
> index 656d6b1dddb5,a89ae84a1fa0..000000000000
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@@ -126,9 -140,7 +140,9 @@@ static int vf610_gpio_direction_output(
>         unsigned long mask = BIT(gpio);
>         u32 val;
>
>  +      vf610_gpio_set(chip, gpio, value);
>  +
> -       if (port->sdata && port->sdata->have_paddr) {
> +       if (port->sdata->have_paddr) {
>                 val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
>                 val |= mask;
>                 vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);

Thanks Stephen, this is correct.

My for-next tree is currently rebased on top of v6.6-rc1 while the
fixes tree tracks Linus' master.

Once the fixes are upstream, I may just rebase my for-next tree.

Bart

linux-next: manual merge of the gpio-brgl tree with the gpio-brgl-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Hi all,

Today's linux-next merge of the gpio-brgl tree got a conflict in:

  drivers/gpio/Kconfig

between commit:

  298d75c9b188 ("gpio: tegra: Add missing dependencies")

from the gpio-brgl-fixes tree and commit:

  355ef6bb005f ("gpio: tegra: Add dependency on GPIOLIB_IRQCHIP")

from the gpio-brgl tree.

I fixed it up (the former is just a superset of the latter) and can
carry the fix as necessary. This is now fixed as far as linux-next is
concerned, but any non trivial conflicts should be mentioned to your
upstream maintainer when your tree is submitted for merging.  You may
also want to consider cooperating with the maintainer of the conflicting
tree to minimise any particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]