public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petar Stoykov <pd.pstoykov@gmail.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Angel Iglesias <ang.iglesiasg@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: pressure: Add driver for Sensirion SDP500
Date: Tue, 30 Apr 2024 18:40:32 +0300	[thread overview]
Message-ID: <ZjEQ8LBxftcr0Z0t@smile.fi.intel.com> (raw)
In-Reply-To: <CADFWO8EQUkGcbE=RXjxXbub2tZge9+ss=gB-Q6wngFAvwFygRg@mail.gmail.com>

On Tue, Apr 30, 2024 at 05:27:24PM +0200, Petar Stoykov wrote:
> From 6ae7537517f551540121ca6fb3b99080b7580410 Mon Sep 17 00:00:00 2001
> From: Petar Stoykov <pd.pstoykov@gmail.com>
> Date: Mon, 15 Jan 2024 12:21:26 +0100
> Subject: [PATCH 2/3] iio: pressure: Add driver for Sensirion SDP500
> 
> Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> accessed over I2C.

Any Datasheet: tag can be added?

...

> +config SDP500
> +    tristate "Sensirion SDP500 differential pressure sensor I2C driver"
> +    depends on I2C
> +    help
> +      Say Y here to build support for Sensirion SDP500 differential pressure
> +      sensor I2C driver.
> +      To compile this driver as a module, choose M here: the core module
> +      will be called sdp500.

You patch is broken. Fix the way how you send patches.

...

> +static int sdp500_start_measurement(struct sdp500_data *data, const
> struct iio_dev *indio_dev)

Here is more visible.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-04-30 15:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 15:27 [PATCH v2 2/3] iio: pressure: Add driver for Sensirion SDP500 Petar Stoykov
2024-04-30 15:40 ` Andy Shevchenko [this message]
2024-05-01 11:48   ` Petar Stoykov
2024-05-01 13:02     ` Konstantin Ryabitsev
2024-05-01  9:44 ` Krzysztof Kozlowski
2024-05-05 17:18 ` Jonathan Cameron
2024-06-10  8:58   ` Petar Stoykov
2024-06-11 17:02     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjEQ8LBxftcr0Z0t@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=ang.iglesiasg@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pd.pstoykov@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox