From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Beleswar Padhi <b-padhi@ti.com>
Cc: andersson@kernel.org, s-anna@ti.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
u-kumar1@ti.com, nm@ti.com, devarsht@ti.com, hnagalla@ti.com
Subject: Re: [PATCH v3 0/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1
Date: Tue, 30 Apr 2024 10:59:31 -0600 [thread overview]
Message-ID: <ZjEjc9kUaGuXYy12@p14s> (raw)
In-Reply-To: <20240430105307.1190615-1-b-padhi@ti.com>
On Tue, Apr 30, 2024 at 04:23:05PM +0530, Beleswar Padhi wrote:
> PSC controller has a limitation that it can only power-up the second core
> when the first core is in ON state. Power-state for core0 should be equal
> to or higher than core1, else the kernel is seen hanging during rproc
> loading.
>
> Make the powering up of cores sequential, by waiting for the current core
> to power-up before proceeding to the next core, with a timeout of 2sec.
> Add a wait queue event in k3_r5_cluster_rproc_init call, that will wait
> for the current core to be released from reset before proceeding with the
> next core.
>
> Also, ensure that core1 can not be powered on before core0 when starting
> cores from sysfs. Similarly, ensure that core0 can not be shutdown
> before core1 from sysfs.
>
> v3: Changelog:
> 1) Added my own Signed-off-by in PATCH 1, specifying the changes done
> 2) Addressed changes requested by adding comments in code in PATCH 1
>
> Link to v2:
> https://lore.kernel.org/all/20240424130504.494916-1-b-padhi@ti.com/
>
> v2: Changelog:
> 1) Fixed multi-line comment format
> 2) Included root cause of bug in comments
> 3) Added a patch to ensure power-up/shutdown is sequential via sysfs
>
> Link to v1:
> https://lore.kernel.org/all/20230906124756.3480579-1-a-nandan@ti.com/
>
> Apurva Nandan (1):
> remoteproc: k3-r5: Wait for core0 power-up before powering up core1
>
> Beleswar Padhi (1):
> remoteproc: k3-r5: Do not allow core1 to power up before core0 via
> sysfs
>
> drivers/remoteproc/ti_k3_r5_remoteproc.c | 56 +++++++++++++++++++++++-
> 1 file changed, 54 insertions(+), 2 deletions(-)
Applied - thanks,
Mathieu
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-04-30 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 10:53 [PATCH v3 0/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1 Beleswar Padhi
2024-04-30 10:53 ` [PATCH v3 1/2] " Beleswar Padhi
2024-04-30 10:53 ` [PATCH v3 2/2] remoteproc: k3-r5: Do not allow core1 to power up before core0 via sysfs Beleswar Padhi
2024-05-18 10:44 ` Christophe JAILLET
2024-05-20 15:14 ` Mathieu Poirier
2024-04-30 16:59 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjEjc9kUaGuXYy12@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=b-padhi@ti.com \
--cc=devarsht@ti.com \
--cc=hnagalla@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=nm@ti.com \
--cc=s-anna@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox