From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7281F51C49 for ; Wed, 1 May 2024 13:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714570610; cv=none; b=lveG/BVKXQUWxwZRWSJKRRkb7pyrSepop0u+TplX5VOxDpuQNPBaF/37Vj7H5NN/wnXoreuAv0aCv1zlGRVcn2CEtaJZUeoHHMOu/7WmfHUrdK3pRmeLR83tMLnV55+LIgzXBzytCcfCqBgWFRtnBwvFGy1gRS2PjB9u07OyRto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714570610; c=relaxed/simple; bh=zTsdvuMoDV5ibhpwBED87HJwZ2l0YhEWLx3/N/6clNY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a8HjqL4UI6JAkajxw0HEnZtiDYJ2YuuTx8bLFs1JDWVCCH6K/VzadOfqBSrFZfGB7dn+V6Vz8Z5aslHB0D0Vx8P494WtMAXDB62jdOcvpF6jiWv0qO3UoMGRyxQ4Qa07+JuKFI/pxYJz9647mzp0bshdUCvWpxN03eGuxYDSOvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E10912F4; Wed, 1 May 2024 06:37:13 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBB9F3F73F; Wed, 1 May 2024 06:36:46 -0700 (PDT) Date: Wed, 1 May 2024 14:36:44 +0100 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V2] firmware: arm_scmi: power_control: support suspend command Message-ID: References: <20240428075105.2187837-1-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240428075105.2187837-1-peng.fan@oss.nxp.com> On Sun, Apr 28, 2024 at 03:51:05PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Support System suspend notification. Using a work struct to call > pm_suspend. There is no way to pass suspend level to pm_suspend, > so use MEM as of now. > > - The choice of S2R(MEM) by default. The userspace can configure whatever > default behaviour expected as S2R, if issuing suspend from userspace. > > - The userspace needs to keep the wakeup source enabled, otherwise the > system may never resume back. > > Signed-off-by: Peng Fan > --- Have you tried triggering a suspend with this on your setup ? Anyway, LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian