From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50063171AA; Thu, 2 May 2024 08:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714638176; cv=none; b=Si6oF4A+YTfY1C3D+6Gd7qnc1To4FtJ1nsJIDqnIxR83hFT9Lh0d5jdCaal+EdqsHO+iKkdKqbdSA++U+hPlQJ5SQt0WSCHpWuQJvFRc1FTGx9JkzqsxunkH9/CuFUITm0SAmsIH4aFYHDbrNmtfejiGxv0kEe3QUYSXGt3Qpmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714638176; c=relaxed/simple; bh=E4+DQxHbmRZH8hQLZzYXl+R8ueZIMSIxWR5jTQDKNyw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TrC4NEGI3Xgb2kjXA7OPpiP7knY9tBSqRd9IPA9SPa1caqMYOdYUJFcv2U5wubjo0L/vlE+XF76ZHPeUWZUUC80h7WpoWIuZn0kBywxyArS6suRvdaCSlWYHDleHsH0qkc37aq0ku6E7zbJBJw3fXgA4lw7azhXn4TuLepKf0kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=f4JUJbMx; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="f4JUJbMx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8wuGpwnMt9ml6C6oIbM/w/YxYBb9yduCe8wSQiSG0GQ=; b=f4JUJbMxmSflXyYq48u1tWnPvt aMmmKJRDROPXBPhaGI0S6qpebizMuULtoyK5xyJufpkKS0qpvB4FHlVh207NAN//CMwTJDPl0gOSM pCTbpLM6vNKIancWKJhrGeCpCEak9gMfhZx0xUmLKQ1B8YH5+UISpPGIfLxWlTHcZP/k2Rl+j9zjw jLdumkt6Ylz0zy32CZbnffN9JyuZpojxsbFCw9qbhWoKUqlzjauhTw8R1fnJnP7VMEiEEUVmxRDJJ uOvEzvq1YjTAclb0at1KqqQOnHC4NytwxruVjw2BdpwLQ7qR/+GfHd9pzODR8URGrxhCt1HMslTUz O2Lj1oIQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52706) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s2RiD-00072I-1g; Thu, 02 May 2024 09:22:41 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s2RiC-0003Vo-1X; Thu, 02 May 2024 09:22:40 +0100 Date: Thu, 2 May 2024 09:22:39 +0100 From: "Russell King (Oracle)" To: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, Duanqiang Wen , mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clkdev: report over-sized strings when creating clkdev entries Message-ID: References: <560549ed7db5da2f2727dc053a5d196d.sboyd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Thu, May 02, 2024 at 09:02:16AM +0100, Russell King (Oracle) wrote: > On Wed, May 01, 2024 at 06:02:54PM -0700, Stephen Boyd wrote: > > Quoting Stephen Boyd (2024-05-01 17:59:16) > > > Quoting Russell King (Oracle) (2024-03-15 04:47:55) > > > > Report an error when an attempt to register a clkdev entry results in a > > > > truncated string so the problem can be easily spotted. > > > > > > > > Reported by: Duanqiang Wen > > > > Signed-off-by: Russell King (Oracle) > > > > --- > > > > > > Applied to clk-next > > > > > > > And backed out because I get a compilation failure > > > > drivers/clk/clkdev.c: In function 'vclkdev_alloc': > > drivers/clk/clkdev.c:182:17: error: function 'vclkdev_alloc' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format] > > 182 | res = vsnprintf(cla->dev_id, sizeof(cla->dev_id), dev_fmt, ap); > > | ^~~ > > cc1: all warnings being treated as errors > > make[5]: *** [scripts/Makefile.build:244: drivers/clk/clkdev.o] Error 1 > > make[4]: *** [scripts/Makefile.build:485: drivers/clk] Error 2 > > It builds fine for me. I don't get this _error_, and it's really no > different from what it originally was - instead of using vcsnprintf() > we're now using vsnprintf(). That should make no difference what so > ever. ... and I've just checked, and it builds entirely cleanly for me. I'll merge it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!