* [PATCH] staging: fb_tinylcd Alignment to open parenthesis [not found] <ZjRDUO6/M+RDCcQJ.ref@c> @ 2024-05-03 1:52 ` Ashok Kumar 2024-05-03 5:11 ` Dan Carpenter 2024-05-03 6:54 ` Julia Lawall 0 siblings, 2 replies; 5+ messages in thread From: Ashok Kumar @ 2024-05-03 1:52 UTC (permalink / raw) To: Greg Kroah-Hartman, dri-devel, linux-fbdev, linux-staging, linux-kernel, outreachy Cc: ashokemailat Corrected coding style CHECK: Alignment should match open parenthesis Signed-off-by: Ashok Kumar <ashokemailat@yahoo.com> --- drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c index 9469248f2c50..60cda57bcb33 100644 --- a/drivers/staging/fbtft/fb_tinylcd.c +++ b/drivers/staging/fbtft/fb_tinylcd.c @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par) write_reg(par, 0xE5, 0x00); write_reg(par, 0xF0, 0x36, 0xA5, 0x53); write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55); write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); udelay(250); -- 2.34.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis 2024-05-03 1:52 ` [PATCH] staging: fb_tinylcd Alignment to open parenthesis Ashok Kumar @ 2024-05-03 5:11 ` Dan Carpenter 2024-05-03 6:54 ` Julia Lawall 1 sibling, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2024-05-03 5:11 UTC (permalink / raw) To: Ashok Kumar Cc: Greg Kroah-Hartman, dri-devel, linux-fbdev, linux-staging, linux-kernel, outreachy On Thu, May 02, 2024 at 06:52:16PM -0700, Ashok Kumar wrote: > Corrected coding style CHECK: Alignment should match open parenthesis > The original author was aligned it deliberately to improve readability. Just ignore checkpatch on this. regards, dan carpenter ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis 2024-05-03 1:52 ` [PATCH] staging: fb_tinylcd Alignment to open parenthesis Ashok Kumar 2024-05-03 5:11 ` Dan Carpenter @ 2024-05-03 6:54 ` Julia Lawall 2024-05-03 16:20 ` Ashok Kumar 1 sibling, 1 reply; 5+ messages in thread From: Julia Lawall @ 2024-05-03 6:54 UTC (permalink / raw) To: Ashok Kumar Cc: Greg Kroah-Hartman, dri-devel, linux-fbdev, linux-staging, linux-kernel, outreachy On Thu, 2 May 2024, Ashok Kumar wrote: > Corrected coding style CHECK: Alignment should match open parenthesis Ashok, I think the code is nicer as is, because it has all the constant numbers lined up. julia > > Signed-off-by: Ashok Kumar <ashokemailat@yahoo.com> > --- > drivers/staging/fbtft/fb_tinylcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c > index 9469248f2c50..60cda57bcb33 100644 > --- a/drivers/staging/fbtft/fb_tinylcd.c > +++ b/drivers/staging/fbtft/fb_tinylcd.c > @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0xE5, 0x00); > write_reg(par, 0xF0, 0x36, 0xA5, 0x53); > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55); > write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); > udelay(250); > -- > 2.34.1 > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis 2024-05-03 6:54 ` Julia Lawall @ 2024-05-03 16:20 ` Ashok Kumar 2024-05-04 11:17 ` Dan Carpenter 0 siblings, 1 reply; 5+ messages in thread From: Ashok Kumar @ 2024-05-03 16:20 UTC (permalink / raw) To: Julia Lawall Cc: Greg Kroah-Hartman, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev On Thursday, May 2, 2024 at 11:54:58 PM PDT, Julia Lawall <julia.lawall@inria.fr> wrote: On Thu, 2 May 2024, Ashok Kumar wrote: > Corrected coding style CHECK: Alignment should match open parenthesis Ashok, I think the code is nicer as is, because it has all the constant numbers lined up. julia Thanks for the update I will ignore this change. Is there a list of exceptions to the checkpatch information that we can ignore in general. > > Signed-off-by: Ashok Kumar <ashokemailat@yahoo.com> > --- > drivers/staging/fbtft/fb_tinylcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c > index 9469248f2c50..60cda57bcb33 100644 > --- a/drivers/staging/fbtft/fb_tinylcd.c > +++ b/drivers/staging/fbtft/fb_tinylcd.c > @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0xE5, 0x00); > write_reg(par, 0xF0, 0x36, 0xA5, 0x53); > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55); > write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); > udelay(250); > -- > 2.34.1 > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: fb_tinylcd Alignment to open parenthesis 2024-05-03 16:20 ` Ashok Kumar @ 2024-05-04 11:17 ` Dan Carpenter 0 siblings, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2024-05-04 11:17 UTC (permalink / raw) To: Ashok Kumar Cc: Julia Lawall, Greg Kroah-Hartman, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev On Fri, May 03, 2024 at 04:20:24PM +0000, Ashok Kumar wrote: > > Is there a list of exceptions to the checkpatch information that we can ignore in general. > For Greg's subsystems ignore the warning about extra parentheses. You can search on lore for if a patch has been patch has been sent before. Otherwise ignore checkpatch if it tells you to do something that makes the code less readable. regards, dan carpenter ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-04 11:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ZjRDUO6/M+RDCcQJ.ref@c>
2024-05-03 1:52 ` [PATCH] staging: fb_tinylcd Alignment to open parenthesis Ashok Kumar
2024-05-03 5:11 ` Dan Carpenter
2024-05-03 6:54 ` Julia Lawall
2024-05-03 16:20 ` Ashok Kumar
2024-05-04 11:17 ` Dan Carpenter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox