* [PATCH v1 1/1] iommu/amd: Fix compilation error
@ 2024-04-29 11:17 Andy Shevchenko
2024-04-29 12:09 ` Jason Gunthorpe
2024-05-03 10:12 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-04-29 11:17 UTC (permalink / raw)
To: Jason Gunthorpe, Vasant Hegde, iommu, linux-kernel, llvm
Cc: Joerg Roedel, Suravee Suthikulpanit, Will Deacon, Robin Murphy,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Andy Shevchenko
With WERROR=y, which is default, clang is not happy:
.../amd/pasid.c:168:3: error: call to undeclared function 'mmu_notifier_unregister'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
.../amd/pasid.c:191:8: error: call to undeclared function 'mmu_notifier_register'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2 errors generated.
Select missed dependency.
Fixes: a5a91e54846d ("iommu/amd: Add SVA domain support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iommu/amd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/amd/Kconfig b/drivers/iommu/amd/Kconfig
index 68d8fc107cb9..994063e5586f 100644
--- a/drivers/iommu/amd/Kconfig
+++ b/drivers/iommu/amd/Kconfig
@@ -7,6 +7,7 @@ config AMD_IOMMU
select PCI_ATS
select PCI_PRI
select PCI_PASID
+ select MMU_NOTIFIER
select IOMMU_API
select IOMMU_IOVA
select IOMMU_IO_PGTABLE
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] iommu/amd: Fix compilation error
2024-04-29 11:17 [PATCH v1 1/1] iommu/amd: Fix compilation error Andy Shevchenko
@ 2024-04-29 12:09 ` Jason Gunthorpe
2024-05-03 10:12 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2024-04-29 12:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Vasant Hegde, iommu, linux-kernel, llvm, Joerg Roedel,
Suravee Suthikulpanit, Will Deacon, Robin Murphy,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt
On Mon, Apr 29, 2024 at 02:17:07PM +0300, Andy Shevchenko wrote:
> With WERROR=y, which is default, clang is not happy:
>
> .../amd/pasid.c:168:3: error: call to undeclared function 'mmu_notifier_unregister'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> .../amd/pasid.c:191:8: error: call to undeclared function 'mmu_notifier_register'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 2 errors generated.
>
> Select missed dependency.
>
> Fixes: a5a91e54846d ("iommu/amd: Add SVA domain support")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iommu/amd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] iommu/amd: Fix compilation error
2024-04-29 11:17 [PATCH v1 1/1] iommu/amd: Fix compilation error Andy Shevchenko
2024-04-29 12:09 ` Jason Gunthorpe
@ 2024-05-03 10:12 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2024-05-03 10:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jason Gunthorpe, Vasant Hegde, iommu, linux-kernel, llvm,
Suravee Suthikulpanit, Will Deacon, Robin Murphy,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt
On Mon, Apr 29, 2024 at 02:17:07PM +0300, Andy Shevchenko wrote:
> drivers/iommu/amd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-03 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 11:17 [PATCH v1 1/1] iommu/amd: Fix compilation error Andy Shevchenko
2024-04-29 12:09 ` Jason Gunthorpe
2024-05-03 10:12 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox