Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

Alex Deucher
2024-05-08T21:12:39Z

On Wed, May 8, 2024 at 4:12 PM Easwar Hariharan
<eahariha@linux.microsoft.com> wrote:
>
> On 5/8/2024 7:53 AM, Alex Deucher wrote:
> > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan
> > <eahariha@linux.microsoft.com> wrote:
> >>
> >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote:
> >>> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> >>> with more appropriate terms. Inspired by and following on to Wolfram's
> >>> series to fix drivers/i2c/[1], fix the terminology for users of
> >>> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> >>> in the specification.
> >>>
> >>> Compile tested, no functionality changes intended
> >>>
> >>> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
> >>>
> >>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
> >>> ---
> >>> .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 +++---
> >>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 10 +++----
> >>> drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 8 +++---
> >>> drivers/gpu/drm/amd/amdgpu/atombios_i2c.h | 2 +-
> >>> drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 20 ++++++-------
> >>> .../gpu/drm/amd/display/dc/bios/bios_parser.c | 2 +-
> >>> .../drm/amd/display/dc/bios/bios_parser2.c | 2 +-
> >>> .../drm/amd/display/dc/core/dc_link_exports.c | 4 +--
> >>> drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
> >>> drivers/gpu/drm/amd/display/dc/dce/dce_i2c.c | 4 +--
> >>> .../display/include/grph_object_ctrl_defs.h | 2 +-
> >>> drivers/gpu/drm/amd/include/atombios.h | 2 +-
> >>> drivers/gpu/drm/amd/include/atomfirmware.h | 26 ++++++++---------
> >>> .../powerplay/hwmgr/vega20_processpptables.c | 4 +--
> >>> .../amd/pm/powerplay/inc/smu11_driver_if.h | 2 +-
> >>> .../inc/pmfw_if/smu11_driver_if_arcturus.h | 2 +-
> >>> .../inc/pmfw_if/smu11_driver_if_navi10.h | 2 +-
> >>> .../pmfw_if/smu11_driver_if_sienna_cichlid.h | 2 +-
> >>> .../inc/pmfw_if/smu13_driver_if_aldebaran.h | 2 +-
> >>> .../inc/pmfw_if/smu13_driver_if_v13_0_0.h | 2 +-
> >>> .../inc/pmfw_if/smu13_driver_if_v13_0_7.h | 2 +-
> >>> .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 +--
> >>> .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 8 +++---
> >>> drivers/gpu/drm/radeon/atombios.h | 16 +++++------
> >>> drivers/gpu/drm/radeon/atombios_i2c.c | 4 +--
> >>> drivers/gpu/drm/radeon/radeon_combios.c | 28 +++++++++----------
> >>> drivers/gpu/drm/radeon/radeon_i2c.c | 10 +++----
> >>> drivers/gpu/drm/radeon/radeon_mode.h | 6 ++--
> >>> 28 files changed, 93 insertions(+), 93 deletions(-)
> >>>
> >>
> >> <snip>
> >>
> >> Hello Christian, Daniel, David, others,
> >>
> >> Could you re-review v2 since the feedback provided in v0 [1] has now been addressed? I can send v3 with
> >> all other feedback and signoffs from the other maintainers incorporated when I have something for amdgpu
> >> and radeon.
> >
> > This seems like a lot of churn. Additionally, a bunch of these
> > headers are shared with other OSes, so it's possible some of the
> > changes may end up getting reverted accidently when we sync up or we
> > may add new headers in new code with the old nomenclature and then
> > we'd need to make sure to adjust it to make sure everything was
> > aligned again. I would just as soon leave things as is, but I'm open
> > to acking them if there is a strong desire to update things.
> >
> > Alex
>
> The way I see it, this is a small downpayment on the debt we have built up so far. Internship
> programs like LF Outreachy to get more underrepresented groups involved in open source are trying to
> change the open source community culture to be more inclusive, but simultaneously rely on the culture
> being welcoming enough as well.
>
> I do see the challenge involved in preserving the changes and ensuring no new code is added with
> outdated nomenclature (but see [1]), but culture changes one person at a time, and I'd encourage the community
> to do the work needed so we can move past our (mostly) inadvertent role in perpetuating it.
>
> That's my 2c (or your sub-unit currency of choice).

Fair enough.
Acked-by: Aex Deucher <alexander.deucher@amd.com>

>
> Easwar
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=49decddd39e5f6132ccd7d9fdc3d7c470b0061bb