Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

Thomas Zimmermann
2024-05-06T09:21:50Z

Am 03.05.24 um 20:13 schrieb Easwar Hariharan:
> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.
>
> Compile tested, no functionality changes intended
>
> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
>
> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
> drivers/video/fbdev/smscufx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
> index 35d682b110c4..5f0dd01fd834 100644
> --- a/drivers/video/fbdev/smscufx.c
> +++ b/drivers/video/fbdev/smscufx.c
> @@ -1292,7 +1292,7 @@ static int ufx_realloc_framebuffer(struct ufx_data *dev, struct fb_info *info)
> return 0;
> }
>
> -/* sets up I2C Controller for 100 Kbps, std. speed, 7-bit addr, master,
> +/* sets up DDC channel for 100 Kbps, std. speed, 7-bit addr, controller mode,
> * restart enabled, but no start byte, enable controller */
> static int ufx_i2c_init(struct ufx_data *dev)
> {
> @@ -1321,7 +1321,7 @@ static int ufx_i2c_init(struct ufx_data *dev)
> /* 7-bit (not 10-bit) addressing */
> tmp &= ~(0x10);
>
> - /* enable restart conditions and master mode */
> + /* enable restart conditions and controller mode */
> tmp |= 0x21;
>
> status = ufx_reg_write(dev, 0x1000, tmp);

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)