From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Xu, Baojun" <baojun.xu@ti.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"Lu, Kevin" <kevin-lu@ti.com>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"Navada Kanyana, Mukund" <navada@ti.com>,
"13916275206@139.com" <13916275206@139.com>,
"P O, Vijeth" <v-po@ti.com>,
"Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"yung-chuan.liao@linux.intel.com"
<yung-chuan.liao@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"soyer@irl.hu" <soyer@irl.hu>
Subject: Re: [EXTERNAL] Re: [PATCH v3 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI
Date: Mon, 6 May 2024 11:44:46 +0300 [thread overview]
Message-ID: <ZjiYflatVz7F_2em@smile.fi.intel.com> (raw)
In-Reply-To: <d96bea0bacc842e0b30a100f43ff264f@ti.com>
On Mon, May 06, 2024 at 07:44:05AM +0000, Xu, Baojun wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: 02 May 2024 18:22
> > To: Xu, Baojun
> > On Thu, Apr 25, 2024 at 07: 54: 41AM +0000, Xu, Baojun wrote:
> > On Thu, Apr 25, 2024 at 07:54:41AM +0000, Xu, Baojun wrote:
> > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > Sent: 18 April 2024 19:56
> > > > On Thu, Apr 18, 2024 at 12: 02: 37PM +0800, Baojun Xu wrote:
> > > > On Thu, Apr 18, 2024 at 12:02:37PM +0800, Baojun Xu wrote:
...
> > > > > sound/pci/hda/Kconfig | 15 +++++++++++++++
> > > > > sound/pci/hda/Makefile | 2 ++
> > > >
> > > Is this correct? You are adding a dead "code", isn't it?
> > >
> > > What's mean "dead code"? After add CONFIG_SND_HDA_SCODEC_TAS2781_SPI=m
> > > in my config file, the whole patch code has worked.
> >
> > Is that file already in the repository?
> > If not, I don't see it in this patch either --> dead code.
>
> When I integrated CONFIG_SND_HDA_SCODEC_TAS2781_SPI and compiled the whole kernel,
> it used to popup the following message for TAS2781 SPI module in first compile:
>
> Build TAS2781 HD-audio side codec support for SPI Bus (SND_HDA_SCODEC_TAS2781_SPI) [N/m/?] (NEW)
>
> Normally, selected m. And TAS2781 SPI module would be compiled.
The above is a dead code if this SPI driver is not yet in the kernel. Is it?
What is the path to it in the current kernel source tree?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-06 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 4:02 [PATCH v3 0/3] ALSA: hda/tas2781: Add tas2781 driver for SPI Baojun Xu
2024-04-18 4:02 ` [PATCH v3 1/3] ALSA: hda/tas2781: Modification for add " Baojun Xu
2024-04-18 11:56 ` Andy Shevchenko
2024-04-25 7:54 ` [EXTERNAL] " Xu, Baojun
2024-05-02 10:22 ` Andy Shevchenko
2024-05-06 7:44 ` Xu, Baojun
2024-05-06 8:44 ` Andy Shevchenko [this message]
2024-05-06 11:16 ` Takashi Iwai
2024-04-18 4:02 ` [PATCH v3 2/3] ALSA: hda/tas2781: Main code of " Baojun Xu
2024-04-18 14:03 ` Andy Shevchenko
2024-04-18 4:02 ` [PATCH v3 3/3] ALSA: hda/tas2781: Firmware load for " Baojun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjiYflatVz7F_2em@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=v-po@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox