[PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

This doesn't look like it was ever used.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 arch/x86/pci/ce4100.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
index 87313701f069e..f5dbd25651e0f 100644
--- a/arch/x86/pci/ce4100.c
+++ b/arch/x86/pci/ce4100.c
@@ -35,12 +35,6 @@ struct sim_dev_reg {
 	struct sim_reg sim_reg;
 };
 
-struct sim_reg_op {
-	void (*init)(struct sim_dev_reg *reg);
-	void (*read)(struct sim_dev_reg *reg, u32 value);
-	void (*write)(struct sim_dev_reg *reg, u32 value);
-};
-
 #define MB (1024 * 1024)
 #define KB (1024)
 #define SIZE_TO_MASK(size) (~(size - 1))
-- 
2.45.0

Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[Ilpo Järvinen]

On Mon, 6 May 2024, linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> This doesn't look like it was ever used.

Don't start with "This" but spell what you're talking about out so it 
can be read and understood without shortlog in Subject (or looking into 
the code change).

> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  arch/x86/pci/ce4100.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
>  	struct sim_reg sim_reg;
>  };
>  
> -struct sim_reg_op {
> -	void (*init)(struct sim_dev_reg *reg);
> -	void (*read)(struct sim_dev_reg *reg, u32 value);
> -	void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -
>  #define MB (1024 * 1024)
>  #define KB (1024)
>  #define SIZE_TO_MASK(size) (~(size - 1))
> 

-- 
 i.

Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[Dr. David Alan Gilbert]

* Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote:
> On Mon, 6 May 2024, linux@treblig.org wrote:
> 
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > This doesn't look like it was ever used.
> 
> Don't start with "This" but spell what you're talking about out so it 
> can be read and understood without shortlog in Subject (or looking into 
> the code change).

I'm of course happy to rework that if it helps you, although
I thought the subject line was sufficient.

Dave

> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  arch/x86/pci/ce4100.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> > index 87313701f069e..f5dbd25651e0f 100644
> > --- a/arch/x86/pci/ce4100.c
> > +++ b/arch/x86/pci/ce4100.c
> > @@ -35,12 +35,6 @@ struct sim_dev_reg {
> >  	struct sim_reg sim_reg;
> >  };
> >  
> > -struct sim_reg_op {
> > -	void (*init)(struct sim_dev_reg *reg);
> > -	void (*read)(struct sim_dev_reg *reg, u32 value);
> > -	void (*write)(struct sim_dev_reg *reg, u32 value);
> > -};
> > -
> >  #define MB (1024 * 1024)
> >  #define KB (1024)
> >  #define SIZE_TO_MASK(size) (~(size - 1))
> > 
> 
> -- 
>  i.
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[Bjorn Helgaas]

On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote:
> > On Mon, 6 May 2024, linux@treblig.org wrote:
> > 
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > This doesn't look like it was ever used.
> > 
> > Don't start with "This" but spell what you're talking about out so it 
> > can be read and understood without shortlog in Subject (or looking into 
> > the code change).
> 
> I'm of course happy to rework that if it helps you, although
> I thought the subject line was sufficient.

It's a minor point, to be sure.  The way I think about this is "an
essay title is not part of the essay itself," so the essay (commit
log) should make sense all by itself.

Bjorn

Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'

[Dr. David Alan Gilbert]

* Bjorn Helgaas (helgaas@kernel.org) wrote:
> On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> > * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote:
> > > On Mon, 6 May 2024, linux@treblig.org wrote:
> > > 
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > > 
> > > > This doesn't look like it was ever used.
> > > 
> > > Don't start with "This" but spell what you're talking about out so it 
> > > can be read and understood without shortlog in Subject (or looking into 
> > > the code change).
> > 
> > I'm of course happy to rework that if it helps you, although
> > I thought the subject line was sufficient.
> 
> It's a minor point, to be sure.  The way I think about this is "an
> essay title is not part of the essay itself," so the essay (commit
> log) should make sense all by itself.

OK, modified v2 sent.

Dave

> Bjorn
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/