From: Breno Leitao <leitao@debian.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
leit@meta.com, "open list:IO_URING" <io-uring@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] io_uring/io-wq: Use set_bit() and test_bit() at worker->flags
Date: Tue, 7 May 2024 02:24:54 -0700 [thread overview]
Message-ID: <ZjnzZhcOQ/xVDU3e@gmail.com> (raw)
In-Reply-To: <b5f7b99c-053d-4df5-9b2b-aaca48e6f7bd@kernel.dk>
Hello Jens,
On Fri, May 03, 2024 at 12:41:38PM -0600, Jens Axboe wrote:
> On 5/3/24 11:37 AM, Breno Leitao wrote:
> > @@ -631,7 +631,8 @@ static int io_wq_worker(void *data)
> > bool exit_mask = false, last_timeout = false;
> > char buf[TASK_COMM_LEN];
> >
> > - worker->flags |= (IO_WORKER_F_UP | IO_WORKER_F_RUNNING);
> > + set_bit(IO_WORKER_F_UP, &worker->flags);
> > + set_bit(IO_WORKER_F_RUNNING, &worker->flags);
>
> You could probably just use WRITE_ONCE() here with the mask, as it's
> setup side.
Nice, I didn't know we could mix and match regular operations and
set_bits(). Digging a bit further, I got that this is possible.
Thanks for the feedback.
prev parent reply other threads:[~2024-05-07 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 17:37 [PATCH] io_uring/io-wq: Use set_bit() and test_bit() at worker->flags Breno Leitao
2024-05-03 18:32 ` Jens Axboe
2024-05-07 10:44 ` Breno Leitao
2024-05-07 11:02 ` Breno Leitao
2024-05-07 13:28 ` Jens Axboe
2024-05-03 18:41 ` Jens Axboe
2024-05-03 19:24 ` Christophe JAILLET
2024-05-03 19:36 ` Jens Axboe
2024-05-07 9:24 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjnzZhcOQ/xVDU3e@gmail.com \
--to=leitao@debian.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=leit@meta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox