From: Nicolas Schier <nicolas@fjasle.eu>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Terrell" <terrelln@fb.com>,
"Björn Töpel" <bjorn@rivosinc.com>
Subject: Re: [PATCH v2 1/2] riscv: make image compression configurable
Date: Tue, 7 May 2024 14:34:09 +0200 [thread overview]
Message-ID: <ZjofwZDHYg8yYKeK@buildd.core.avm.de> (raw)
In-Reply-To: <20240504193446.196886-2-emil.renner.berthing@canonical.com>
On Sat, May 04, 2024 at 09:34:38PM +0200, Emil Renner Berthing wrote:
> Previously the build process would always set KBUILD_IMAGE to the
> uncompressed Image file (unless XIP_KERNEL or EFI_ZBOOT was enabled) and
> unconditionally compress it into Image.gz. However there are already
> build targets for Image.bz2, Image.lz4, Image.lzma, Image.lzo and
> Image.zstd, so let's make use of those, make the compression method
> configurable and set KBUILD_IMAGE accordingly so that targets like
> 'make install' and 'make bindeb-pkg' will use the chosen image.
>
> Tested-by: Björn Töpel <bjorn@rivosinc.com>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---
> Changes in v2:
> - Rebase on riscv/for-next
> - Use boot-image-$(CONFIG_..) := assignments rather than ifeq train
> ---
Looks good to me.
Reviewed-by: Nicolas Schier <n.schier@avm.de>
next prev parent reply other threads:[~2024-05-07 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 19:34 [PATCH v2 0/2] riscv: make image compression configurable Emil Renner Berthing
2024-05-04 19:34 ` [PATCH v2 1/2] " Emil Renner Berthing
2024-05-07 12:34 ` Nicolas Schier [this message]
2024-05-07 14:26 ` Masahiro Yamada
2024-05-04 19:34 ` [PATCH v2 2/2] riscv: show help string for riscv-specific targets Emil Renner Berthing
2024-05-07 14:26 ` Masahiro Yamada
2024-05-15 13:40 ` [PATCH v2 0/2] riscv: make image compression configurable patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjofwZDHYg8yYKeK@buildd.core.avm.de \
--to=nicolas@fjasle.eu \
--cc=bjorn@rivosinc.com \
--cc=emil.renner.berthing@canonical.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox