Re: [PATCH 02/13] mfd: pm8008: fix regmap irq chip initialisation

Andy Shevchenko
2024-05-07T17:17:23Z

On Tue, May 7, 2024 at 6:01 PM Johan Hovold <johan@kernel.org> wrote:
> On Mon, May 06, 2024 at 09:56:05PM +0300, Andy Shevchenko wrote:
> > Mon, May 06, 2024 at 05:08:19PM +0200, Johan Hovold kirjoitti:
> > > The regmap irq array is potentially shared between multiple PMICs and

...

> > > - dev_err(dev, "Failed to probe irq periphs: %d\n", rc);
> > > + dev_err(dev, "failed to add IRQ chip: %d\n", rc);
> >
> > dev_err_probe(...); ?
>
> This function won't return -EPROBE_DEFER,

This is not an argument for a long time (since documentation of
dev_err_probe() had been amended to encourage its use for any error
cases in probe).

> and that would be a separate
> change in any case.

Sure, but why to add a technical debt? Perhaps a precursor cleanup patch?

--
With Best Regards,
Andy Shevchenko