Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver

Mark Brown
2024-05-08T11:41:47Z

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Tue, May 07, 2024 at 08:22:34PM +0300, Andy Shevchenko wrote:
> On Tue, May 7, 2024 at 6:44 PM Johan Hovold <johan@kernel.org> wrote:

> > > > [ johan: rework probe to match new binding, amend commit message and
> > > > Kconfig entry]

> > > Wouldn't be better on one line?

> > Now you're really nit picking. ;) I think I prefer to stay within 72
> > columns.

> Not really. The tag block is special and the format is rather one
> entry per line. This might break some scriptings.

No, really - the above is absolutely fine, random notes in the middle of
things are reasonably common and scripting that can't cope with them is
going to encounter a bunch of problems. This stuff needs to be readable
by humans and this is just a stylistic preference on your part.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]