Re: [PATCH 03/13] mfd: pm8008: deassert reset on probe

Andy Shevchenko
2024-05-06T18:58:18Z

Mon, May 06, 2024 at 05:08:20PM +0200, Johan Hovold kirjoitti:
> Request and deassert any (optional) reset gpio during probe in case it
> has been left asserted by the boot firmware.
>
> Note the reset line is not asserted to avoid reverting to the default
> I2C address in case the firmware has configured an alternate address.

...

> + reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR(reset))
> + return PTR_ERR(reset);

Shouldn't you wait a bit to make chip settle down?

--
With Best Regards,
Andy Shevchenko