Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver

Andy Shevchenko
2024-05-09T12:07:05Z

Wed, May 08, 2024 at 10:37:50PM +0000, Stephen Boyd kirjoitti:
> Quoting Johan Hovold (2024-05-06 08:08:29)

...

> > + BUILD_BUG_ON((ARRAY_SIZE(pldo_ranges) != 1) ||
>
> This should be an && not || right?

> > + (ARRAY_SIZE(nldo_ranges) != 1));

In any case BUILD_BUG_ON() is not encouraged for such cases, it would be much
better to have a static_assert() near to one of those arrays.

--
With Best Regards,
Andy Shevchenko