Re: [PATCH 10/13] dt-bindings: mfd: pm8008: rework binding

Johan Hovold
2024-05-07T15:23:03Z

On Tue, May 07, 2024 at 08:43:08AM +0200, Krzysztof Kozlowski wrote:
> On 06/05/2024 17:08, Johan Hovold wrote:
> > Rework the pm8008 binding by dropping internal details like register
> > offsets and interrupts and by adding the missing regulator and
> > temperature alarm properties.
> >
> > Note that child nodes are still used for pinctrl and regulator
> > configuration.
> >
> > Also note that the pinctrl state definition will be extended later and
> > could eventually also be shared with other PMICs (e.g. by breaking out
> > bits of qcom,pmic-gpio.yaml).
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

> > reg:
> > - description:
> > - I2C slave address.
>
> Please split cleanups from actual functional/content rework.

Sure.

> > -
> > maxItems: 1
> >
> > interrupts:
> > maxItems: 1
> >
> > - description: Parent interrupt.
> > -
> > reset-gpios:
> > maxItems: 1
> >
> > - "#interrupt-cells":
> > + vdd_l1_l2-supply: true
>
> No underscores in property names.

Indeed. These names come from Qualcomm's v15, but I should have caught
that. Thanks.

Johan