Re: [PATCH 10/13] dt-bindings: mfd: pm8008: rework binding

Krzysztof Kozlowski
2024-05-07T06:43:15Z

On 06/05/2024 17:08, Johan Hovold wrote:
> Rework the pm8008 binding by dropping internal details like register
> offsets and interrupts and by adding the missing regulator and
> temperature alarm properties.
>
> Note that child nodes are still used for pinctrl and regulator
> configuration.
>
> Also note that the pinctrl state definition will be extended later and
> could eventually also be shared with other PMICs (e.g. by breaking out
> bits of qcom,pmic-gpio.yaml).
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 154 ++++++++++--------
> 1 file changed, 90 insertions(+), 64 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> index e1e05921afb4..ac1bab0261b6 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
> @@ -19,116 +19,142 @@ properties:
> const: qcom,pm8008
>
> reg:
> - description:
> - I2C slave address.

Please split cleanups from actual functional/content rework.

> -
> maxItems: 1
>
> interrupts:
> maxItems: 1
>
> - description: Parent interrupt.
> -
> reset-gpios:
> maxItems: 1
>
> - "#interrupt-cells":
> + vdd_l1_l2-supply: true

No underscores in property names.

Best regards,
Krzysztof