Re: [RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

Christoph Hellwig
2024-05-06T12:04:49Z

On Fri, May 03, 2024 at 01:10:44PM -0700, Mina Almasry wrote:
> Is the concern still that folks may be able to hook proprietary stuff
> into this like you mentioned before[1]?

That is on concern. The other is that people will do stupid stuff
even in tree if you give them enough rope, and they should not have
that rope when the only sensible options are page/folio based kernel
memory (incuding large/huge folios) and dmabuf.

> cp net/core/page_pool.c net/core/dmabuf_pool.c
>
> and then modify it such that the net stack maintains 2 page_pools?
> There are a lot of cons to that:

No. Just have branches for page based vs dmabuf in a few places.