From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS
Date: Wed, 8 May 2024 21:28:58 +0300 [thread overview]
Message-ID: <ZjvEam5paLD0Iv6V@smile.fi.intel.com> (raw)
In-Reply-To: <6599e2a3-3b04-4ea2-aa5c-a916b66c8009@kernel.org>
On Wed, May 08, 2024 at 08:15:00PM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2024 19:53, Andy Shevchenko wrote:
> > On Sun, Apr 14, 2024 at 05:49:57PM +0200, Krzysztof Kozlowski wrote:
> >> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> >> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
> >> the alias to be duplicated.
...
> >> MODULE_ALIAS("spi:93xx46");
> >
> > I was stumbled over this (leftover?).
> > Commit message doesn't elaborate this bit.
> > Any comments?
>
> It is not present in ID table and commit msg removes only duplicated
> aliases. That alias has meaning - someone might be actually relying on it.
It seems no users for it. The only user of platform data of this EEPROM uses
board files which AFAIU bypasses modalias matching.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-08 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 15:49 [PATCH 1/2] eeprom: at25: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2024-04-14 15:49 ` [PATCH] mtd: mchp23k256: " Krzysztof Kozlowski
2024-04-14 15:49 ` [PATCH 2/2] eeprom: 93xx46: " Krzysztof Kozlowski
2024-05-08 17:53 ` Andy Shevchenko
2024-05-08 18:15 ` Krzysztof Kozlowski
2024-05-08 18:28 ` Andy Shevchenko [this message]
2024-05-08 18:44 ` Krzysztof Kozlowski
2024-05-08 19:11 ` Arnd Bergmann
2024-05-08 19:17 ` Krzysztof Kozlowski
2024-05-10 14:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjvEam5paLD0Iv6V@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox