From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F258131724; Thu, 9 May 2024 12:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715257598; cv=none; b=GOeqnkcs6tOmK3i27LPe/BAPS8MkS5VMUCdVKjISAE3VXNvaRxiWOCqv0cJoKa8mb11XgUlXNQ66Uq4YEOQm7h8umiRC6aZFy+kSwQzYPmsjW20j2lBgOKnzwYhqlvcBRT69OogSTKGwzWImcenlLIz0hBQ41SmYaeECFKAhxAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715257598; c=relaxed/simple; bh=muhLaR/99OohMazNTK3EQ6x8cOUF9aDaLDgAy9OKcnI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VNymEGVD2WZeTZVWog9vRF7eYt6qbKeMIyrWcM0S1MvHOvxXxH3e+aiEpmIiqQuuaAFb/MV1Zzd1AmlzerSGb/V3tbg0smQSct0v0q98BmvCIKfzrkS32iDAJOdO1oW5NN7iaLL9w3QYKJosHg9ADmgBCWTh10Cnqcty1bXYrpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PmJnbjrE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PmJnbjrE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2964C116B1; Thu, 9 May 2024 12:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715257598; bh=muhLaR/99OohMazNTK3EQ6x8cOUF9aDaLDgAy9OKcnI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PmJnbjrEYJyK+T9V3AkzDCD8reMggyIyDpOGh93DB3EZkpRXPqj7aAaOWdSqQ5w/L YNEbf/Z5fa7OAGgLeejIvByuaYEMJrIq6aWXIXyyPQ6nrEIg5R0LHrYa//E/wIBP/j IEz3b+I1yG4lagxa9xL3i0G38xY2lwM/u9oOA+OFMN2Sxg6dbk4OyVh636daaLduYS N8U+FfTFuoHHAhEk3Ziw7DZfjXkFMdWwQZe3u1x9laGlytrtcJNshV26iKqS89Qps2 cYsBuFmVwjykBlskqISRp8RjP0BStukDIykVjWQDnO9Kxg2GQKAnwchHK8KPp6FH5B HbTnJHd4gIX0A== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1s52rC-000000004wl-0Rll; Thu, 09 May 2024 14:26:42 +0200 Date: Thu, 9 May 2024 14:26:42 +0200 From: Johan Hovold To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Andy Shevchenko , Krzysztof Kozlowski , Johan Hovold , Lee Jones , Mark Brown , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Das Srinagesh , Satya Priya , Stephen Boyd , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver Message-ID: References: <20240506150830.23709-1-johan+linaro@kernel.org> <20240506150830.23709-13-johan+linaro@kernel.org> <8d2ea17c-f91e-4e14-a239-e5e999f6ac50@linaro.org> <1df61b7c-29c4-4537-a0b6-75785606eeae@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1df61b7c-29c4-4537-a0b6-75785606eeae@kernel.org> On Thu, May 09, 2024 at 12:48:18PM +0200, Krzysztof Kozlowski wrote: > On 09/05/2024 10:57, Johan Hovold wrote: > > On Tue, May 07, 2024 at 08:14:43PM +0200, Krzysztof Kozlowski wrote: > >> On 07/05/2024 19:22, Andy Shevchenko wrote: > >> Yeah, please use ID table, since this is a driver (unless I missed > >> something). Module alias does not scale, leads to stale and duplicated > >> entries, so should not be used as substitute of ID table. Alias is > >> suitable for different cases. > > > > There's no scalability issue here. If the driver uses driver name > > matching then there will always be exactly one alias needed. > > And then we add one more ID with driver data and how does it scale? That's what I wrote in the part of my reply that you left out. If a driver is going to be used for multiple devices, then a module id table makes sense, but there is no need to go around adding redundant tables just for the sake of it when a simple alias will do. Johan