From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EDCA17EF for ; Thu, 23 May 2024 00:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716425431; cv=none; b=JyYhBSVUaLAGE6sGRtwV5y/jCk/K9HerzfZg2A9CV1zhxR87bxXaUbSiMbwmQsOTh42kwGRRXtjoyU5WA4vo5eEB9rEEWX6MlCkWFBlPLmf4h4A4nL34E8MFgEJ1TBdEFor2/B+OxlvYwNvIm/UZTSHcHbYM9VNMYoc7WRdK0H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716425431; c=relaxed/simple; bh=UbwQHGJBE6SZy3dTvzmiW3Y7u7jPztiPZ4sdWKIuK9M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rKbSi8bOm0uuXAVPfb2qjZUYclmL+JyeFTbwuKHCBIrz+TKsb0fMPcNfINnEglS9pOnM+wGRIVzxAEBjlu62GNktTsSDJ5yRGc+aJC01OademSEhy6u5HDLH4vQOWLOrIi9/o4ap5Xf5fXiKdiIb230GxPBQ3KpFAVmwcO+8J8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=HjX8ixgg; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HjX8ixgg" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1edfc57ac0cso15088745ad.3 for ; Wed, 22 May 2024 17:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1716425429; x=1717030229; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/bNuy6SM/kLB6qLCSNaw2T+XxnPO+OsFpO7610Vx//k=; b=HjX8ixggKAjeqRU17T6IPgVoQlI7BnR5bE5FnPdqVNcq5gS3kLGTMayAu52XGMxIGs IhYPuW7x4Wp8aEId7JTpOckT314Evr4uVSl3mvXqKyQ+dYTq7MUKYATR5gQh48M13iPJ gvQpwKYtRKLJP9/S5C41Aa05UOaPnWH3lnjBM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716425429; x=1717030229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/bNuy6SM/kLB6qLCSNaw2T+XxnPO+OsFpO7610Vx//k=; b=m2gdD23e0LhKz1gEPNr++UklR30u9Zi+lby0YDguoduLhmT0n47IZfrBi9iyHt1a7J 7bcUZoxMMiZANDkEMxt8gyLEdVJqMa28k4g9ykCP6Ur19hwLkArAVmBJfHm/jYEtW+8J 2odym+HpLC+oeWHWYN2dhggtE2PmXTBrODvdYqGgsNDtdsi1troKjmOLZ2qJmsqVAn0V gEv8p3fer/7cDBVyk+L5rPANP+vrmvYkm97nB3foBTVjskpO0z59G/4c5UZhr6mECaHj 086s+h+ghv1FEQF6yas76Zfa+IXD52PDbMzqZ5+E96WYm7nXeBtId8Cnzb7w4xbC40nV b+Fw== X-Forwarded-Encrypted: i=1; AJvYcCU9QHuXc1W4khR8ziQgDZy29wNszboYKBvlr8/T+E1c4d2bhxn2aLCMoN4XvO6Fi1ii89Eee2Tx47rrf6qEVpJ55KgLijupTIvD3Czb X-Gm-Message-State: AOJu0YzLFSG0p7wwlAMK2UEfQSciqfArSBxSJrUPC5nV3kJeIO9i5Dax swP0TJTezmdw8y5V49ruE8XfYk1uKrW03SNoeF+qMCi2CagxL9vPPgVqkU/yweKguj+QQRl5jWw = X-Google-Smtp-Source: AGHT+IEdMYJvguszZWQhcagUOIsDBSSSsuIKGnskWDfANoYCNYn6AMpeqnKTOXyc04/jjf4/0L64nw== X-Received: by 2002:a17:902:e944:b0:1f2:f6ca:fbca with SMTP id d9443c01a7336-1f31c976c1emr37161985ad.9.1716425429401; Wed, 22 May 2024 17:50:29 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:3a97:1cc8:ab6c:8d0f]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-1f326bd5b70sm17699125ad.237.2024.05.22.17.50.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 17:50:28 -0700 (PDT) Date: Wed, 22 May 2024 17:50:26 -0700 From: Brian Norris To: David Lin Cc: Marcel Holtmann , "linux-wireless@vger.kernel.org" , LKML , Kalle Valo , "francesco@dolcini.it" , Pete Hsieh , "rafael.beims" , Francesco Dolcini Subject: Re: [EXT] [PATCH v10 0/2] wifi: mwifiex: add code to support host mlme Message-ID: References: <6CB59E09-F34E-4986-AA88-8EC4EE5E71DF@holtmann.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 13, 2024 at 01:27:13AM +0000, David Lin wrote: > > From: David Lin > > Sent: Thursday, May 2, 2024 4:35 PM > > > > 1. The process of external_auth should be as follows: > > a. cfg80211_ops.connect() is called to establish connection with remote > > AP. > > b. If authentication is not WLAN_AUTH_SAE, FW will process > > authentication/association > > and reply connection result to cfg80211. > > c. If authentication is WLAN_AUTH_SAE, FW should notify driver to call > > cfg80211_external_auth_request() to offload authentication to > > wpa_supplicant. FWIW, I expect you could just as well teach the driver to detect this -- I don't think we'd strictly require that firmware notify the driver. Essentially, you could teach the driver to notice any sort of CONNECT request (e.g., keep a list of FW-supported WLAN_AUTH_* modes?) that the firmware can't handle on its own, and begin the external_auth() process. I'm not sure this is ideal, but it does sound doable even without FW notification. > > d. FW will wait for authentication result passed by > > cfg80211_ops.external_auth() to > > decide if association should be processed with remote AP for the original > > connection > > request and reply connection result to cfg80211. > > NXP FW only supports association with or without authentication, it can't > > support external_auth. But could it support my above description? Basically, the driver decides whether to submit the connection request directly to the firmware, or go with external_auth() instead. > > 2. Hook separating auth/assoc will offload SME to wpa_supplicant > > completely. Driver/FW don't need > > to involve the process of authentication just like external_auth did. There > > is no effort for driver/FW > > to support any future modifications of authentication process. > > Can we confirm that hooking separating auth/assoc is more suitable than "external_auth" for mwifiex? I have one clarification question above. And I haven't heard anything more from Marcel, so assuming the above is clarified, I suppose we can drop the external_auth question. Brian