From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3D2120DF7 for ; Mon, 13 May 2024 17:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715621614; cv=none; b=Tx8oYtsAEWhunVb3smPY7UPMaOBbkvxxRVvvbdpGC2czP+uz+7WBMKGbtLk3J9CfYn6T9m6Gs1q7iVlXvKvkBnQocb9CQV1aa70ZZnz84jpgCQeGaw5NddEBbjJOox2LCDOWDBoZjCbd649jj2D99A0X/4V1+qFRSirVRo6iM6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715621614; c=relaxed/simple; bh=004wZ/BTyT9fE4JXjqxo7dvB6azeLVxU7gAlJEphKdU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zeq2U1IpGWWpyUrdZHw8B+eqGw/2Ycu1BAg/y1ijX3BGj/sTVdse+XB7z04SzbtQChgFFVJipWL0jyPWBi1a7THxgyZw3HmzhBXXU84A2HQTNe/HYicBb+vH4ITFGRgSSOiRvCpDhetSzIxwsszEviG8oGDWOxruDVWl1j0nyJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=PBHbiJ16; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="PBHbiJ16" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-5aa3f0fcd46so2789076eaf.1 for ; Mon, 13 May 2024 10:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1715621612; x=1716226412; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=nWgFC3S2PfP1iJSh371S2lssW1zUAEloG1SEMk5tnQo=; b=PBHbiJ16yUyRq8xxXOantAlgyE+09KxSYjBca7c1xc4qrO7q0VcT1Jd86n/6qd2N0n L8hp46JRPfQEs9ncx3lrKtwI4o0tLCDylmw8DicDZDngxrxs+7ECFbH0+B9LsTtr2cUj KG+Lh/nwg5DSwJL7rYxyzx2LhBz1xsEYVWX5o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715621612; x=1716226412; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nWgFC3S2PfP1iJSh371S2lssW1zUAEloG1SEMk5tnQo=; b=uJNDScbZczRjemDzXujS+HJrDtendbrgFUu061V5bpBqdTm/x7fVeAvlEeg6ZD8cZL mwAgAKgk0yWBIkDXZzbUaRJxRZmJWj76QhGCg5HUXnudXLrB4OOPHkOhVlcmElkVopMJ P4gQAx9bdtlWI9qE3VX5t7E/3zSeBM2G0qR3pDgG54aZd7XxQboBM/jz7MY7dZkfWB1E prJYT57vpGw6T5ZsZywgepDY65Jl5tHdr9ll2knVaxZscGK/RW+NxBHSqZ70cBXFdUM9 bT9UxTc+Dah++1S9+tm23HOfKIy1D8jbRufLDRwXnwOWs/tVeq6X8yyCDZgqXQaw/EmR 1aJQ== X-Forwarded-Encrypted: i=1; AJvYcCW9+9T8cMST2y8O4YD0et9mf0qVcCfe/C6qX2eLeB5aa1l1LFHjgUGUt1AUIm3dgcOT3jZzw75CYollqpX27NChGWnfDmSmVrkPGNur X-Gm-Message-State: AOJu0YxxH0v8UCh0/SFHM6x265As+ZgIfAJp8sn3tUIBdNCMppCfujrp G6pHtidwMHHvMS9Di1SGH/seY8RIRwhpZkzkFLpPamYjt2ITKREuS24RQbOcox4= X-Google-Smtp-Source: AGHT+IGLySbm6b/4r6B+YP3EJ/0D5HsDixyPGRii0Uq+ZLUeYN7X2cixlwoD4AR5edXW/aNBuPaBkA== X-Received: by 2002:a05:6870:c185:b0:22e:a451:57d1 with SMTP id 586e51a60fabf-24172f69da0mr10682085fac.52.1715621612005; Mon, 13 May 2024 10:33:32 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6340a449e0esm7969360a12.13.2024.05.13.10.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 10:33:31 -0700 (PDT) Date: Mon, 13 May 2024 10:33:28 -0700 From: Joe Damato To: Jakub Kicinski Cc: Tariq Toukan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, zyjzyj2000@gmail.com, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , "open list:MELLANOX MLX5 core VPI driver" Subject: Re: [PATCH net-next v2 1/1] net/mlx5e: Add per queue netdev-genl stats Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , Tariq Toukan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, zyjzyj2000@gmail.com, nalramli@fastly.com, Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , "open list:MELLANOX MLX5 core VPI driver" References: <20240510041705.96453-1-jdamato@fastly.com> <20240510041705.96453-2-jdamato@fastly.com> <20240513075827.66d42cc1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240513075827.66d42cc1@kernel.org> On Mon, May 13, 2024 at 07:58:27AM -0700, Jakub Kicinski wrote: > On Fri, 10 May 2024 04:17:04 +0000 Joe Damato wrote: > > Add functions to support the netdev-genl per queue stats API. > > > > ./cli.py --spec netlink/specs/netdev.yaml \ > > --dump qstats-get --json '{"scope": "queue"}' > > > > ...snip > > > > {'ifindex': 7, > > 'queue-id': 62, > > 'queue-type': 'rx', > > 'rx-alloc-fail': 0, > > 'rx-bytes': 105965251, > > 'rx-packets': 179790}, > > {'ifindex': 7, > > 'queue-id': 0, > > 'queue-type': 'tx', > > 'tx-bytes': 9402665, > > 'tx-packets': 17551}, > > > > ...snip > > > > Also tested with the script tools/testing/selftests/drivers/net/stats.py > > in several scenarios to ensure stats tallying was correct: > > > > - on boot (default queue counts) > > - adjusting queue count up or down (ethtool -L eth0 combined ...) > > - adding mqprio TCs > > > > Signed-off-by: Joe Damato > > Tariq, could you take a look? Is it good enough to make 6.10? > Would be great to have it.. Thanks Jakub. FYI: I've also sent a v5 of the mlx4 patches which is only a very minor change from the v4 as suggested by Tariq (see the changelog in that cover letter). I am not trying to "rush" either in, to to speak, but if they both made it to 6.10 it would be great to have the same support on both drivers in the same kernel release :)