From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, bard.liao@intel.com,
yung-chuan.liao@linux.intel.com, kevin-lu@ti.com,
cameron.berkenpas@gmail.com, tiwai@suse.de, baojun.xu@ti.com,
soyer@irl.hu, Baojun.Xu@fpt.com
Subject: Re: [RESEND PATCH v5 1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence
Date: Fri, 17 May 2024 16:50:25 +0300 [thread overview]
Message-ID: <ZkdgocpiPpGKYVMo@smile.fi.intel.com> (raw)
In-Reply-To: <20240517092039.688-1-shenghao-ding@ti.com>
On Fri, May 17, 2024 at 05:20:36PM +0800, Shenghao Ding wrote:
> Remove declaration of unused API which load calibrated data in wrong
> sequence, changed the copyright year and correct file name in license
> header.
> -int tasdevice_prmg_calibdata_load(void *context, int prm_no);
You remove a prototype before removing the function, correct?
You have for all these versions even not _build_ tested your changes.
NAK.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-05-17 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 9:20 [RESEND PATCH v5 1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence Shenghao Ding
2024-05-17 9:20 ` [RESEND PATCH v5 2/3] " Shenghao Ding
2024-05-17 9:20 ` [RESEND PATCH v5 3/3] " Shenghao Ding
2024-05-17 9:36 ` [RESEND PATCH v5 1/3] " Takashi Iwai
2024-05-17 13:50 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkdgocpiPpGKYVMo@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=cameron.berkenpas@gmail.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox