From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Ben Walsh <ben@jubnut.com>
Cc: "Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
"Kieran Levin" <ktl@frame.work>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] platform/chrome: cros_ec_lpc: Pass driver_data in static variable
Date: Mon, 20 May 2024 17:46:45 +0800 [thread overview]
Message-ID: <ZkscBbImKiLJxaBn@google.com> (raw)
In-Reply-To: <20240515055631.5775-4-ben@jubnut.com>
On Wed, May 15, 2024 at 06:56:28AM +0100, Ben Walsh wrote:
> The module init passed extra data to the driver via the driver_data of
> a new platform device. But when an ACPI device already existed, no
> platform device was created, so this extra data wasn't passed to the
> driver.
>
> Stop using the driver_data and use a static variable instead.
Could it be possible to put the driver data in the acpi_device_id and
somewhere calls acpi_device_get_match_data()?
next prev parent reply other threads:[~2024-05-20 9:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 5:56 [PATCH 0/6] Fix MEC concurrency problems for Framework Laptop Ben Walsh
2024-05-15 5:56 ` [PATCH 1/6] platform/chrome: cros_ec_lpc: MEC access can return error code Ben Walsh
2024-05-20 9:45 ` Tzung-Bi Shih
2024-05-15 5:56 ` [PATCH 2/6] platform/chrome: cros_ec_lpc: MEC access can use an AML mutex Ben Walsh
2024-05-20 9:46 ` Tzung-Bi Shih
2024-05-15 5:56 ` [PATCH 3/6] platform/chrome: cros_ec_lpc: Pass driver_data in static variable Ben Walsh
2024-05-20 9:46 ` Tzung-Bi Shih [this message]
2024-05-15 5:56 ` [PATCH 4/6] platform/chrome: cros_ec_lpc: Add a new quirk for AML mutex Ben Walsh
2024-05-15 5:56 ` [PATCH 5/6] platform/chrome: cros_ec_lpc: Correct ACPI name for Framework Laptop Ben Walsh
2024-05-20 9:47 ` Tzung-Bi Shih
2024-05-23 18:42 ` Ben Walsh
2024-05-24 2:26 ` Tzung-Bi Shih
2024-05-24 18:35 ` Ben Walsh
2024-05-24 18:39 ` Dustin Howett
2024-05-24 18:45 ` Ben Walsh
2024-05-26 1:26 ` Tzung-Bi Shih
2024-05-27 18:06 ` Ben Walsh
2024-05-28 3:08 ` Tzung-Bi Shih
2024-05-15 5:56 ` [PATCH 6/6] platform/chrome: cros_ec_lpc: Add AML mutex " Ben Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkscBbImKiLJxaBn@google.com \
--to=tzungbi@kernel.org \
--cc=ben@jubnut.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=ktl@frame.work \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox