From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: Daniel Latypov <dlatypov@google.com>,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.gaignard@collabora.com, sebastian.fricke@collabora.com,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
adobriyan@gmail.com, jani.nikula@intel.com,
p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
laurent.pinchart@ideasonboard.com, praneeth@ti.com, nm@ti.com,
vigneshr@ti.com, a-bhatia1@ti.com, j-luthra@ti.com,
b-brnich@ti.com, detheridge@ti.com, p-mantena@ti.com,
vijayp@ti.com, andrzej.p@collabora.com, nicolas@ndufresne.ca,
davidgow@google.com
Subject: Re: [PATCH v8 07/10] lib: add basic KUnit test for lib/math
Date: Mon, 20 May 2024 15:22:47 +0300 [thread overview]
Message-ID: <ZktAlza1zEke1eCx@smile.fi.intel.com> (raw)
In-Reply-To: <7b8cd37b-5b16-2d99-ab62-5d6876e6571c@ti.com>
On Mon, May 20, 2024 at 05:11:18PM +0530, Devarsh Thakkar wrote:
> On 18/05/24 01:44, Andy Shevchenko wrote:
> > On Fri, May 17, 2024 at 11:06:07PM +0530, Devarsh Thakkar wrote:
[..]
> >> +#include <kunit/test.h>
> >> +#include <linux/gcd.h>
> >
> >> +#include <linux/kernel.h>
> >
> > Do you know why this header is included?
>
> It includes all the other required headers (including those you mentioned
> below), and header list is probably copied from other files in same directory.
> But it does suffice the requirements as I have verified the compilation.
Yes, and one should follow IWYU principle and not cargo cult or whatever
arbitrary lists.
> >> +#include <linux/lcm.h>
> >
> > + math.h // obviously
> > + module.h
> >
> >> +#include <linux/reciprocal_div.h>
> >
> > + types.h
>
> All the above headers are already included as part of kernel.h
Yes, that's why you should not use "proxy" headers.
Have you read the top comment in the kernel.h?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-20 12:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 17:15 [PATCH v8 00/10] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2024-05-17 17:19 ` [PATCH v8 01/10] media: dt-bindings: Add Imagination " Devarsh Thakkar
2024-05-17 17:28 ` [PATCH v8 02/10] media: imagination: Add E5010 JPEG Encoder driver Devarsh Thakkar
2024-05-17 17:31 ` [PATCH v8 03/10] media: v4l2-jpeg: Export reference quantization and huffman tables Devarsh Thakkar
2024-05-17 17:32 ` [PATCH v8 04/10] media: imagination: Use exported tables from v4l2-jpeg core Devarsh Thakkar
2024-05-17 17:33 ` [PATCH v8 05/10] media: verisilcon : Use exported tables from v4l2-jpeg for hantro codec Devarsh Thakkar
2024-05-17 17:34 ` [PATCH v8 06/10] math.h: Add macros for rounding to closest value Devarsh Thakkar
2024-05-17 17:36 ` [PATCH v8 07/10] lib: add basic KUnit test for lib/math Devarsh Thakkar
2024-05-17 20:14 ` Andy Shevchenko
2024-05-17 20:53 ` Daniel Latypov
2024-05-20 9:26 ` Andy Shevchenko
2024-05-20 11:41 ` Devarsh Thakkar
2024-05-20 12:22 ` Andy Shevchenko [this message]
2024-05-20 14:21 ` Devarsh Thakkar
2024-05-20 14:35 ` Andy Shevchenko
2024-05-17 17:37 ` [PATCH v8 08/10] lib: math_kunit: Add tests for new rounding related macros Devarsh Thakkar
2024-05-17 17:38 ` [PATCH v8 09/10] media: imagination: Round to closest multiple for cropping region Devarsh Thakkar
2024-05-17 17:40 ` [PATCH v8 10/10] gpu: ipu-v3: Use generic macro for rounding closest to specified value Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZktAlza1zEke1eCx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a-bhatia1@ti.com \
--cc=adobriyan@gmail.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox