From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v5 21/30] printk: nbcon: Use nbcon consoles in console_flush_all()
Date: Tue, 21 May 2024 10:41:38 +0200 [thread overview]
Message-ID: <ZkxeQsaPcTIbkqMZ@pathway.suse.cz> (raw)
In-Reply-To: <20240502213839.376636-22-john.ogness@linutronix.de>
On Thu 2024-05-02 23:44:30, John Ogness wrote:
> Allow nbcon consoles to print messages in the legacy printk()
> caller context (printing via unlock) by integrating them into
> console_flush_all(). The write_atomic() callback is used for
> printing.
>
> Provide nbcon_legacy_emit_next_record(), which acts as the
> nbcon variant of console_emit_next_record(). Call this variant
> within console_flush_all() for nbcon consoles. Since nbcon
> consoles use their own @nbcon_seq variable to track the next
> record to print, this also must be appropriately handled in
> console_flush_all().
>
> Note that the legacy printing logic uses @handover to detect
> handovers for printing all consoles. For nbcon consoles,
> handovers/takeovers occur on a per-console basis and thus do
> not cause the console_flush_all() loop to abort.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2024-05-21 8:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:38 [PATCH printk v5 00/30] wire up write_atomic() printing John Ogness
2024-05-02 21:38 ` [PATCH printk v5 01/30] printk: Add notation to console_srcu locking John Ogness
2024-05-07 12:16 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 02/30] printk: Properly deal with nbcon consoles on seq init John Ogness
2024-05-02 21:38 ` [PATCH printk v5 03/30] printk: nbcon: Remove return value for write_atomic() John Ogness
2024-05-02 21:38 ` [PATCH printk v5 04/30] printk: Check printk_deferred_enter()/_exit() usage John Ogness
2024-05-02 21:38 ` [PATCH printk v5 05/30] printk: nbcon: Add detailed doc for write_atomic() John Ogness
2024-05-07 12:26 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 06/30] printk: nbcon: Add callbacks to synchronize with driver John Ogness
2024-05-17 13:31 ` Petr Mladek
2024-05-17 14:00 ` John Ogness
2024-05-17 14:40 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 07/30] printk: nbcon: Use driver synchronization while (un)registering John Ogness
2024-05-06 10:27 ` John Ogness
2024-05-17 13:44 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 08/30] serial: core: Provide low-level functions to lock port John Ogness
2024-05-02 21:38 ` [PATCH printk v5 09/30] serial: core: Introduce wrapper to set @uart_port->cons John Ogness
2024-05-03 8:09 ` Théo Lebrun
2024-05-04 16:08 ` Greg Kroah-Hartman
2024-05-17 14:51 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 10/30] console: Improve console_srcu_read_flags() comments John Ogness
2024-05-17 14:55 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 11/30] nbcon: Provide functions for drivers to acquire console for non-printing John Ogness
2024-05-06 10:29 ` John Ogness
2024-05-20 12:13 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 12/30] serial: core: Implement processing in port->lock wrapper John Ogness
2024-05-04 16:08 ` Greg Kroah-Hartman
2024-05-20 12:22 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 13/30] printk: nbcon: Do not rely on proxy headers John Ogness
2024-05-02 21:38 ` [PATCH printk v5 14/30] printk: nbcon: Fix kerneldoc for enums John Ogness
2024-05-02 21:38 ` [PATCH printk v5 15/30] printk: Make console_is_usable() available to nbcon John Ogness
2024-05-02 21:38 ` [PATCH printk v5 16/30] printk: Let console_is_usable() handle nbcon John Ogness
2024-05-02 21:38 ` [PATCH printk v5 17/30] printk: Add @flags argument for console_is_usable() John Ogness
2024-05-02 21:38 ` [PATCH printk v5 18/30] printk: nbcon: Add helper to assign priority based on CPU state John Ogness
2024-05-02 21:38 ` [PATCH printk v5 19/30] printk: nbcon: Provide function to flush using write_atomic() John Ogness
2024-05-20 15:04 ` Petr Mladek
2024-05-21 19:07 ` John Ogness
2024-05-02 21:38 ` [PATCH printk v5 20/30] printk: Track registered boot consoles John Ogness
2024-05-02 21:38 ` [PATCH printk v5 21/30] printk: nbcon: Use nbcon consoles in console_flush_all() John Ogness
2024-05-21 8:41 ` Petr Mladek [this message]
2024-05-02 21:38 ` [PATCH printk v5 22/30] printk: nbcon: Add unsafe flushing on panic John Ogness
2024-05-02 21:38 ` [PATCH printk v5 23/30] printk: Avoid console_lock dance if no legacy or boot consoles John Ogness
2024-05-02 21:38 ` [PATCH printk v5 24/30] printk: Track nbcon consoles John Ogness
2024-05-02 21:38 ` [PATCH printk v5 25/30] printk: Coordinate direct printing in panic John Ogness
2024-05-02 21:38 ` [PATCH printk v5 26/30] printk: nbcon: Implement emergency sections John Ogness
2024-05-06 10:39 ` John Ogness
2024-05-21 12:37 ` Petr Mladek
2024-05-21 13:38 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 27/30] panic: Mark emergency section in warn John Ogness
2024-05-02 21:38 ` [PATCH printk v5 28/30] panic: Mark emergency section in oops John Ogness
2024-05-02 21:38 ` [PATCH printk v5 29/30] rcu: Mark emergency sections in rcu stalls John Ogness
2024-05-21 14:03 ` Petr Mladek
2024-05-02 21:38 ` [PATCH printk v5 30/30] lockdep: Mark emergency sections in lockdep splats John Ogness
2024-05-21 15:13 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkxeQsaPcTIbkqMZ@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox