From: Petr Mladek <pmladek@suse.com>
To: "gxxa03070307@gmail.com" <gxxa03070307@gmail.com>
Cc: "john.ogness" <john.ogness@linutronix.de>,
rostedt <rostedt@goodmis.org>,
senozhatsky <senozhatsky@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
fengqi <fengqi@xiaomi.com>, 高翔 <gaoxiang19870307@163.com>
Subject: Re: [PATCH] printk: Increase PRINTK_PREFIX_MAX and the buf size in print_caller.
Date: Mon, 3 Jun 2024 14:42:44 +0200 [thread overview]
Message-ID: <Zl26LDOV_v946kOv@pathway.suse.cz> (raw)
In-Reply-To: <1717404421510.qmo40jy5kubcunlrdknzajsf@android.mail.163.com>
On Mon 2024-06-03 16:47:01, gxxa03070307@gmail.com wrote:
> I need to populate the temporary variable "caller" in "print_caller" func with the additional information. And it's no use defining a buf in out-of-tree patch.
> In out-of-tree patch, I can only add hooks (special cases), I can't change anything else, because it needs to be consistent with mainline linux.
> caller buf in mainline linux is it better to make the buf bigger and leave some space?
I do not understand. Why the buffer size has to be consistent with
mainline linux?
Really, it does not make much sense to upstream just this part
of your out-of-tree patch?
Best Regards,
Petr
next prev parent reply other threads:[~2024-06-03 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 9:19 [PATCH] printk: Increase PRINTK_PREFIX_MAX and the buf size in print_caller Xiang Gao
2024-05-27 14:54 ` Petr Mladek
2024-05-29 6:33 ` John Ogness
[not found] ` <1717404421510.qmo40jy5kubcunlrdknzajsf@android.mail.163.com>
2024-06-03 12:42 ` Petr Mladek [this message]
2024-06-03 13:15 ` gxxa03070307
2024-06-03 14:59 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl26LDOV_v946kOv@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=fengqi@xiaomi.com \
--cc=gaoxiang19870307@163.com \
--cc=gxxa03070307@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox