From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Ben Walsh <ben@jubnut.com>
Cc: "Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
"Kieran Levin" <ktl@frame.work>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] platform/chrome: cros_ec_lpc: Add a new quirk for AML mutex
Date: Mon, 3 Jun 2024 09:31:13 +0000 [thread overview]
Message-ID: <Zl2NYTIWtt604WXm@google.com> (raw)
In-Reply-To: <20240603063834.5580-5-ben@jubnut.com>
On Mon, Jun 03, 2024 at 07:38:33AM +0100, Ben Walsh wrote:
> @@ -484,6 +492,18 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
> }
> ACPI_COMPANION_SET(dev, adev);
> }
> +
> + if (quirks & CROS_EC_LPC_QUIRK_AML_MUTEX) {
> + const char *name
> + = driver_data->quirk_aml_mutex_name;
> + ret = cros_ec_lpc_mec_acpi_mutex(adev, name);
* Assuming the `adev = ACPI_COMPANION(dev);` didn't move in previous patch,
`adev` here could be uninitialized.
* Also, it shouldn't rely on CROS_EC_LPC_QUIRK_ACPI_ID to set the `adev`.
To keep it simple, I would suggest to use ACPI_COMPANION() instead.
next prev parent reply other threads:[~2024-06-03 9:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 6:38 [PATCH v2 0/5] platform/chrome: Fix MEC concurrency problems for Framework Laptop Ben Walsh
2024-06-03 6:38 ` [PATCH v2 1/5] platform/chrome: cros_ec_lpc: MEC access can return error code Ben Walsh
2024-06-03 9:30 ` Tzung-Bi Shih
2024-06-03 19:26 ` Ben Walsh
2024-06-03 6:38 ` [PATCH v2 2/5] platform/chrome: cros_ec_lpc: MEC access can use an AML mutex Ben Walsh
2024-06-03 9:30 ` Tzung-Bi Shih
2024-06-03 6:38 ` [PATCH v2 3/5] platform/chrome: cros_ec_lpc: Add a new quirk for ACPI id Ben Walsh
2024-06-03 9:30 ` Tzung-Bi Shih
2024-06-03 16:00 ` Mario Limonciello
2024-06-03 19:10 ` Ben Walsh
2024-06-04 2:30 ` Tzung-Bi Shih
2024-06-03 6:38 ` [PATCH v2 4/5] platform/chrome: cros_ec_lpc: Add a new quirk for AML mutex Ben Walsh
2024-06-03 9:31 ` Tzung-Bi Shih [this message]
2024-06-03 6:38 ` [PATCH v2 5/5] platform/chrome: cros_ec_lpc: Add quirks for Framework Laptop Ben Walsh
2024-06-03 18:28 ` [PATCH v2 0/5] platform/chrome: Fix MEC concurrency problems " Dustin Howett
2024-06-03 19:06 ` Ben Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl2NYTIWtt604WXm@google.com \
--to=tzungbi@kernel.org \
--cc=ben@jubnut.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dustin@howett.net \
--cc=groeck@chromium.org \
--cc=ktl@frame.work \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox