public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro
@ 2024-06-03  2:50 Jeff Johnson
  2024-06-03  7:55 ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Jeff Johnson @ 2024-06-03  2:50 UTC (permalink / raw)
  To: Andy Shevchenko, Geert Uytterhoeven
  Cc: linux-kernel, kernel-janitors, Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/hd44780_common.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/auxdisplay/hd44780_common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/hd44780_common.c b/drivers/auxdisplay/hd44780_common.c
index 7cbf375b0fa5..4ef87c3118c0 100644
--- a/drivers/auxdisplay/hd44780_common.c
+++ b/drivers/auxdisplay/hd44780_common.c
@@ -366,4 +366,5 @@ struct hd44780_common *hd44780_common_alloc(void)
 }
 EXPORT_SYMBOL_GPL(hd44780_common_alloc);
 
+MODULE_DESCRIPTION("Common functions for HD44780 (and compatibles) LCD displays");
 MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-drivers-auxdisplay-hd44780-7e6b8c681277


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro
  2024-06-03  2:50 [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-03  7:55 ` Geert Uytterhoeven
  2024-06-03 19:49   ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2024-06-03  7:55 UTC (permalink / raw)
  To: Jeff Johnson; +Cc: Andy Shevchenko, linux-kernel, kernel-janitors

On Mon, Jun 3, 2024 at 4:50 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/hd44780_common.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro
  2024-06-03  7:55 ` Geert Uytterhoeven
@ 2024-06-03 19:49   ` Andy Shevchenko
  2024-07-23 18:22     ` Jeff Johnson
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-06-03 19:49 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Jeff Johnson, linux-kernel, kernel-janitors

On Mon, Jun 03, 2024 at 09:55:00AM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 3, 2024 at 4:50 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> > make allmodconfig && make W=1 C=1 reports:
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/hd44780_common.o
> >
> > Add the missing invocation of the MODULE_DESCRIPTION() macro.
> >
> > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro
  2024-06-03 19:49   ` Andy Shevchenko
@ 2024-07-23 18:22     ` Jeff Johnson
  2024-07-25  8:54       ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Jeff Johnson @ 2024-07-23 18:22 UTC (permalink / raw)
  To: Andy Shevchenko, Geert Uytterhoeven
  Cc: linux-kernel, kernel-janitors, Greg KH

On 6/3/2024 12:49 PM, Andy Shevchenko wrote:
> On Mon, Jun 03, 2024 at 09:55:00AM +0200, Geert Uytterhoeven wrote:
>> On Mon, Jun 3, 2024 at 4:50 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>>> make allmodconfig && make W=1 C=1 reports:
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/hd44780_common.o
>>>
>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>
>> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Pushed to my review and testing queue, thanks!
> 

Hi Andy,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks
/jeff

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro
  2024-07-23 18:22     ` Jeff Johnson
@ 2024-07-25  8:54       ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2024-07-25  8:54 UTC (permalink / raw)
  To: Jeff Johnson; +Cc: Andy Shevchenko, linux-kernel, kernel-janitors, Greg KH

Hi Jeff,

On Tue, Jul 23, 2024 at 8:22 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> On 6/3/2024 12:49 PM, Andy Shevchenko wrote:
> > On Mon, Jun 03, 2024 at 09:55:00AM +0200, Geert Uytterhoeven wrote:
> >> On Mon, Jun 3, 2024 at 4:50 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> >>> make allmodconfig && make W=1 C=1 reports:
> >>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/hd44780_common.o
> >>>
> >>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
> >>>
> >>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> >>
> >> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Pushed to my review and testing queue, thanks!
> >
>
> Hi Andy,
> I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
> Will you be able to have this pulled during the merge window?
> I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks for reminding us!  I have just sent an auxdisplay PR to Linus,
including your changes, so I hope they end up in his tree soon.

https://lore.kernel.org/all/20240725084741.2519888-1-geert@linux-m68k.org/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-07-25  8:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03  2:50 [PATCH] auxdisplay: hd44780: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03  7:55 ` Geert Uytterhoeven
2024-06-03 19:49   ` Andy Shevchenko
2024-07-23 18:22     ` Jeff Johnson
2024-07-25  8:54       ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox