Re: [PATCH v2 3/4] soundwire: bus: clean up probe warnings

Pierre-Louis Bossart
2024-06-04T08:37:57Z

On 6/4/24 02:52, Johan Hovold wrote:
> Clean up the probe warning messages by using a common succinct format
> (e.g. without __func__ and with a space after ':').
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/soundwire/bus_type.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index 3979be0f8b65..43e732ca73c0 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -123,7 +123,7 @@ static int sdw_drv_probe(struct device *dev)
> /* init the dynamic sysfs attributes we need */
> ret = sdw_slave_sysfs_dpn_init(slave);
> if (ret < 0)
> - dev_warn(dev, "Slave sysfs init failed:%d\n", ret);
> + dev_warn(dev, "failed to initialise sysfs: %d\n", ret);
>
> /*
> * Check for valid clk_stop_timeout, use DisCo worst case value of
> @@ -147,7 +147,7 @@ static int sdw_drv_probe(struct device *dev)
> if (drv->ops && drv->ops->update_status) {
> ret = drv->ops->update_status(slave, slave->status);
> if (ret < 0)
> - dev_warn(dev, "%s: update_status failed with status %d\n", __func__, ret);
> + dev_warn(dev, "failed to update status: %d\n", ret);

the __func__ does help IMHO, 'failed to update status' is way too general...
Replacing 'with status' by ":" is fine, but do we really care about 10
chars in a log?