From: Johan Hovold <johan@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message
Date: Tue, 4 Jun 2024 11:24:55 +0200 [thread overview]
Message-ID: <Zl7dZ-4ysKC-jSA6@hovoldconsulting.com> (raw)
In-Reply-To: <e1c63097-b628-4c97-add6-40fa479a7806@linux.intel.com>
On Tue, Jun 04, 2024 at 10:37:17AM +0200, Pierre-Louis Bossart wrote:
> On 6/4/24 02:52, Johan Hovold wrote:
> > Drop the redundant probe debug message which is already provided by
> > driver core. Whether probe succeeded can also be determined through
> > sysfs.
> > @@ -152,8 +152,6 @@ static int sdw_drv_probe(struct device *dev)
> >
> > mutex_unlock(&slave->sdw_dev_lock);
> >
> > - dev_dbg(dev, "probe complete\n");
> > -
> > return 0;
> > }
>
> I don't see the point of removing this, we've used it for the last 5
> years to figure out when the probe complete vs. when the device becomes
> attached. It's a simple log that helped us immensely with race
> conditions, etc.
Fair enough. Soundwire probing is indeed a bit of a mess.
Johan
prev parent reply other threads:[~2024-06-04 9:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 7:52 [PATCH v2 0/4] soundwire: bus: suppress probe deferral errors Johan Hovold
2024-06-04 7:52 ` [PATCH v2 1/4] " Johan Hovold
2024-06-04 8:30 ` Pierre-Louis Bossart
2024-06-04 9:09 ` Johan Hovold
2024-06-04 13:29 ` Pierre-Louis Bossart
2024-06-04 7:52 ` [PATCH v2 2/4] soundwire: bus: drop unused driver name field Johan Hovold
2024-06-04 7:52 ` [PATCH v2 3/4] soundwire: bus: clean up probe warnings Johan Hovold
2024-06-04 8:33 ` Pierre-Louis Bossart
2024-06-04 9:17 ` Johan Hovold
2024-06-04 13:43 ` Pierre-Louis Bossart
2024-06-04 14:18 ` Johan Hovold
2024-06-04 15:07 ` Pierre-Louis Bossart
2024-06-05 12:11 ` Johan Hovold
2024-06-05 16:15 ` Pierre-Louis Bossart
2024-06-04 7:52 ` [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message Johan Hovold
2024-06-04 8:37 ` Pierre-Louis Bossart
2024-06-04 9:24 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl7dZ-4ysKC-jSA6@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox