Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHY Gen4 x4

Krzysztof Kozlowski
2024-06-04T11:37:50Z

On 04/06/2024 13:17, Johan Hovold wrote:
> On Tue, Jun 04, 2024 at 01:00:35PM +0200, Krzysztof Kozlowski wrote:
>> On 03/06/2024 14:43, Johan Hovold wrote:
>>> On Fri, May 31, 2024 at 07:06:44PM +0300, Abel Vesa wrote:
>>>> The PCIe 6th instance from X1E80100 can be used in both 4-lane mode or
>>>
>>> nit: s/PCIe 6th/sixth PCIe/
>>> nit: s/from/on/
>>> nit: s/both/either/
>>
>> That's really nit-picking and not helpful in getting things merged.
>
> Writing proper commit messages with correct grammar is in no way to be
> asking too much (especially from experienced kernel devs).

Well, many of us are not native English speakers, so when the commit msg
is 100% understandable, pointing out grammar mistakes or style
(6th->sixth) issues is nit-picking and is asking for unnecessary work.

>
> Also, the code does not work so it should not be merged yet anyway.

OK

Best regards,
Krzysztof