Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add X1E80100 Gen4 4-lane mode support

Abel Vesa
2024-06-04T12:25:56Z

On 24-06-03 14:46:12, Johan Hovold wrote:
> On Fri, May 31, 2024 at 07:06:45PM +0300, Abel Vesa wrote:
> > The PCIe 6th instance from X1E80100 can be used in both 4-lane mode or
> > 2-lane mode. Add the configuration and compatible for the 4-lane mode.
>
> Same language nits as for patch 1/1.
>
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>
> I tried this patch along with the DT changes and the link on the CRD
> still comes up as 2-lane:
>
> qcom-pcie 1bf8000.pci: PCIe Gen.4 x2 link up
>
> so something appears to be wrong here. (I noticed the same with your
> next branch last week.)
>
> How did you test this? Does the link actually come up as 4-lane for you?

This is the PHY part. The controller needs some changes as well.

Yes, as of yet, I'm not able to bring the link up in 4-lanes mode.
This however doesn't mean the PHY sequence is incorrect.

But, I agree, maybe I should hold on to the PHY changes as well until
we get the controller side working as well.

Thanks for reviewing.

>
> Johan