From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.gaignard@collabora.com, sebastian.fricke@collabora.com,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
adobriyan@gmail.com, jani.nikula@intel.com,
p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
laurent.pinchart@ideasonboard.com, praneeth@ti.com, nm@ti.com,
vigneshr@ti.com, a-bhatia1@ti.com, j-luthra@ti.com,
b-brnich@ti.com, detheridge@ti.com, p-mantena@ti.com,
vijayp@ti.com, andrzej.p@collabora.com, nicolas@ndufresne.ca,
davidgow@google.com, dlatypov@google.com
Subject: Re: [PATCH v9 07/10] lib: add basic KUnit test for lib/math
Date: Mon, 27 May 2024 23:38:05 +0300 [thread overview]
Message-ID: <ZlTvLS8oTPcvZKQN@smile.fi.intel.com> (raw)
In-Reply-To: <ZlTu_9orsuosNiGk@smile.fi.intel.com>
On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote:
> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote:
...
> > +MODULE_LICENSE("GPL");
>
> modpost validator won't be happy about this, i.e. missing MODULE_DESCRIPTION().
And obviously + module.h in the inclusion block.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-27 20:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 17:56 [PATCH v9 00/10] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2024-05-26 18:05 ` [PATCH v9 01/10] media: dt-bindings: Add Imagination " Devarsh Thakkar
2024-05-26 18:06 ` [PATCH v9 02/10] media: imagination: Add E5010 JPEG Encoder driver Devarsh Thakkar
2024-05-26 18:07 ` [PATCH v9 03/10] media: v4l2-jpeg: Export reference quantization and huffman tables Devarsh Thakkar
2024-05-26 18:07 ` [PATCH v9 04/10] media: imagination: Use exported tables from v4l2-jpeg core Devarsh Thakkar
2024-05-26 18:08 ` [PATCH v9 05/10] media: verisilcon : Use exported tables from v4l2-jpeg for hantro codec Devarsh Thakkar
2024-05-26 18:08 ` [PATCH v9 06/10] math.h: Add macros for rounding to closest value Devarsh Thakkar
2024-05-27 20:32 ` Andy Shevchenko
2024-05-28 10:32 ` Devarsh Thakkar
2024-05-29 13:17 ` Andy Shevchenko
2024-05-26 18:09 ` [PATCH v9 07/10] lib: add basic KUnit test for lib/math Devarsh Thakkar
2024-05-27 20:37 ` Andy Shevchenko
2024-05-27 20:38 ` Andy Shevchenko [this message]
2024-05-28 11:31 ` Devarsh Thakkar
2024-05-29 14:35 ` Andy Shevchenko
2024-05-28 11:21 ` Devarsh Thakkar
2024-05-29 14:34 ` Andy Shevchenko
2024-05-26 18:10 ` [PATCH v9 08/10] lib: math_kunit: Add tests for new macros related to rounding to nearest value Devarsh Thakkar
2024-05-26 18:10 ` [PATCH v9 09/10] media: imagination: Round to closest multiple for cropping region Devarsh Thakkar
2024-05-26 18:11 ` [PATCH v9 10/10] gpu: ipu-v3: Use generic macro for rounding closest to specified value Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlTvLS8oTPcvZKQN@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a-bhatia1@ti.com \
--cc=adobriyan@gmail.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox