* [PATCH] locking/ww_mutex/test: add MODULE_DESCRIPTION()
@ 2024-05-25 0:18 Jeff Johnson
2024-05-28 18:00 ` Boqun Feng
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnson @ 2024-05-25 0:18 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Will Deacon, Waiman Long, Boqun Feng
Cc: linux-kernel, kernel-janitors, Jeff Johnson
Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
kernel/locking/test-ww_mutex.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
index 78719e1ef1b1..0fab96137ddb 100644
--- a/kernel/locking/test-ww_mutex.c
+++ b/kernel/locking/test-ww_mutex.c
@@ -695,5 +695,6 @@ static void __exit test_ww_mutex_exit(void)
module_init(test_ww_mutex_init);
module_exit(test_ww_mutex_exit);
+MODULE_DESCRIPTION("API test facility for ww_mutexes");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Intel Corporation");
---
base-commit: 07506d1011521a4a0deec1c69721c7405c40049b
change-id: 20240524-md-test-ww_mutex-c18c263bc483
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] locking/ww_mutex/test: add MODULE_DESCRIPTION()
2024-05-25 0:18 [PATCH] locking/ww_mutex/test: add MODULE_DESCRIPTION() Jeff Johnson
@ 2024-05-28 18:00 ` Boqun Feng
2024-05-28 20:16 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Boqun Feng @ 2024-05-28 18:00 UTC (permalink / raw)
To: Jeff Johnson
Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Waiman Long,
linux-kernel, kernel-janitors
On Fri, May 24, 2024 at 05:18:11PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> kernel/locking/test-ww_mutex.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
> index 78719e1ef1b1..0fab96137ddb 100644
> --- a/kernel/locking/test-ww_mutex.c
> +++ b/kernel/locking/test-ww_mutex.c
> @@ -695,5 +695,6 @@ static void __exit test_ww_mutex_exit(void)
> module_init(test_ww_mutex_init);
> module_exit(test_ww_mutex_exit);
>
> +MODULE_DESCRIPTION("API test facility for ww_mutexes");
This looks good to me, but seems to me MODULE_DESCRIPTION() is usually
placed after MODULE_AUTHOR(), could you reorder it a bit? Thanks!
Regards,
Boqun
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Intel Corporation");
>
> ---
> base-commit: 07506d1011521a4a0deec1c69721c7405c40049b
> change-id: 20240524-md-test-ww_mutex-c18c263bc483
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] locking/ww_mutex/test: add MODULE_DESCRIPTION()
2024-05-28 18:00 ` Boqun Feng
@ 2024-05-28 20:16 ` Jeff Johnson
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-05-28 20:16 UTC (permalink / raw)
To: Boqun Feng
Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Waiman Long,
linux-kernel, kernel-janitors
On 5/28/2024 11:00 AM, Boqun Feng wrote:
> On Fri, May 24, 2024 at 05:18:11PM -0700, Jeff Johnson wrote:
>> Fix the 'make W=1' warning:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> kernel/locking/test-ww_mutex.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
>> index 78719e1ef1b1..0fab96137ddb 100644
>> --- a/kernel/locking/test-ww_mutex.c
>> +++ b/kernel/locking/test-ww_mutex.c
>> @@ -695,5 +695,6 @@ static void __exit test_ww_mutex_exit(void)
>> module_init(test_ww_mutex_init);
>> module_exit(test_ww_mutex_exit);
>>
>> +MODULE_DESCRIPTION("API test facility for ww_mutexes");
>
>
> This looks good to me, but seems to me MODULE_DESCRIPTION() is usually
> placed after MODULE_AUTHOR(), could you reorder it a bit? Thanks!
Sure, no problem. v2 coming up.
(I had automated placing an empty MODULE_DESCRIPTION() before MODULE_LICENSE()
since every module has a license but not all have authors).
/jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-28 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-25 0:18 [PATCH] locking/ww_mutex/test: add MODULE_DESCRIPTION() Jeff Johnson
2024-05-28 18:00 ` Boqun Feng
2024-05-28 20:16 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox