From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Gwenael Treuveur <gwenael.treuveur@foss.st.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Subject: Re: [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing
Date: Tue, 28 May 2024 13:38:09 -0600 [thread overview]
Message-ID: <ZlYyoZzOlXylkQqC@p14s> (raw)
In-Reply-To: <20240521162316.156259-1-gwenael.treuveur@foss.st.com>
On Tue, May 21, 2024 at 06:23:16PM +0200, Gwenael Treuveur wrote:
> Manage interrupt coming from coprocessor also when state is
> ATTACHED.
>
> Fixes: 35bdafda40cc ("remoteproc: stm32_rproc: Add mutex protection for workqueue")
> Signed-off-by: Gwenael Treuveur <gwenael.treuveur@foss.st.com>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
I will pickup this patch but this time only - next time all reviews and tagging
need to happend on the mailing list.
Mathieu
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 88623df7d0c3..8c7f7950b80e 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -294,7 +294,7 @@ static void stm32_rproc_mb_vq_work(struct work_struct *work)
>
> mutex_lock(&rproc->lock);
>
> - if (rproc->state != RPROC_RUNNING)
> + if (rproc->state != RPROC_RUNNING && rproc->state != RPROC_ATTACHED)
> goto unlock_mutex;
>
> if (rproc_vq_interrupt(rproc, mb->vq_id) == IRQ_NONE)
>
> base-commit: 4d5ba6ead1dc9fa298d727e92db40cd98564d1ac
> --
> 2.25.1
>
prev parent reply other threads:[~2024-05-28 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 16:23 [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing Gwenael Treuveur
2024-05-28 19:38 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlYyoZzOlXylkQqC@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=gwenael.treuveur@foss.st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox