* [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing
@ 2024-05-21 16:23 Gwenael Treuveur
2024-05-28 19:38 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Gwenael Treuveur @ 2024-05-21 16:23 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier
Cc: linux-remoteproc, linux-kernel, linux-stm32, Arnaud Pouliquen,
Gwenael Treuveur
Manage interrupt coming from coprocessor also when state is
ATTACHED.
Fixes: 35bdafda40cc ("remoteproc: stm32_rproc: Add mutex protection for workqueue")
Signed-off-by: Gwenael Treuveur <gwenael.treuveur@foss.st.com>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
---
drivers/remoteproc/stm32_rproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index 88623df7d0c3..8c7f7950b80e 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -294,7 +294,7 @@ static void stm32_rproc_mb_vq_work(struct work_struct *work)
mutex_lock(&rproc->lock);
- if (rproc->state != RPROC_RUNNING)
+ if (rproc->state != RPROC_RUNNING && rproc->state != RPROC_ATTACHED)
goto unlock_mutex;
if (rproc_vq_interrupt(rproc, mb->vq_id) == IRQ_NONE)
base-commit: 4d5ba6ead1dc9fa298d727e92db40cd98564d1ac
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing
2024-05-21 16:23 [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing Gwenael Treuveur
@ 2024-05-28 19:38 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2024-05-28 19:38 UTC (permalink / raw)
To: Gwenael Treuveur
Cc: Bjorn Andersson, linux-remoteproc, linux-kernel, linux-stm32,
Arnaud Pouliquen
On Tue, May 21, 2024 at 06:23:16PM +0200, Gwenael Treuveur wrote:
> Manage interrupt coming from coprocessor also when state is
> ATTACHED.
>
> Fixes: 35bdafda40cc ("remoteproc: stm32_rproc: Add mutex protection for workqueue")
> Signed-off-by: Gwenael Treuveur <gwenael.treuveur@foss.st.com>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
I will pickup this patch but this time only - next time all reviews and tagging
need to happend on the mailing list.
Mathieu
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 88623df7d0c3..8c7f7950b80e 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -294,7 +294,7 @@ static void stm32_rproc_mb_vq_work(struct work_struct *work)
>
> mutex_lock(&rproc->lock);
>
> - if (rproc->state != RPROC_RUNNING)
> + if (rproc->state != RPROC_RUNNING && rproc->state != RPROC_ATTACHED)
> goto unlock_mutex;
>
> if (rproc_vq_interrupt(rproc, mb->vq_id) == IRQ_NONE)
>
> base-commit: 4d5ba6ead1dc9fa298d727e92db40cd98564d1ac
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-28 19:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 16:23 [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing Gwenael Treuveur
2024-05-28 19:38 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox