From: Christoph Hellwig <hch@infradead.org>
To: Li Nan <linan666@huaweicloud.com>
Cc: Christoph Hellwig <hch@infradead.org>,
song@kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v2] md: make md_flush_request() more readable
Date: Tue, 28 May 2024 22:44:03 -0700 [thread overview]
Message-ID: <ZlbAo1XgsPAxQ2Qe@infradead.org> (raw)
In-Reply-To: <bc582a25-2124-2aa8-f26b-94fd5a50f900@huaweicloud.com>
On Tue, May 28, 2024 at 09:49:44PM +0800, Li Nan wrote:
>
>
> 在 2024/5/28 21:23, Christoph Hellwig 写道:
> > Looks good:
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >
> > .
> As suggested by Kuai, I will use bio_sectors instead of bi_size in v3.
>
> - if (bio->bi_iter.bi_size == 0) {
> + if (!bio_sectors(bio)) {
That looks weird. bio_sectors literally just shifts
bio->bi_iter.bi_size to be in units of sectors, which doesn't
matter for comparing with 0.
next prev parent reply other threads:[~2024-05-29 5:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 20:31 [PATCH v2] md: make md_flush_request() more readable linan666
2024-05-28 13:23 ` Christoph Hellwig
2024-05-28 13:49 ` Li Nan
2024-05-29 5:44 ` Christoph Hellwig [this message]
2024-05-29 6:08 ` Yu Kuai
2024-05-29 6:09 ` Christoph Hellwig
2024-05-28 13:32 ` Yu Kuai
2024-06-10 20:53 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlbAo1XgsPAxQ2Qe@infradead.org \
--to=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox