From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: "Steinar H. Gunderson" <sesse@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
irogers@google.com, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v7 1/4] perf report: Support LLVM for addr2line()
Date: Wed, 29 May 2024 10:52:59 -0300 [thread overview]
Message-ID: <ZlczO4D8J1lgWBZj@x1> (raw)
In-Reply-To: <CAM9d7chY7CzMx9sSYeagDK81PsE=soGmn4AUxXAE7rHp=jmx3Q@mail.gmail.com>
On Tue, May 28, 2024 at 08:56:47PM -0700, Namhyung Kim wrote:
> On Sun, May 26, 2024 at 11:22 AM Steinar H. Gunderson <sesse@google.com> wrote:
> > +#elif defined(HAVE_LIBBFD_SUPPORT)
> Hmm.. it's unfortunate that we have only one addr2line
> implementation at a time. Maybe we can do the same thing
> like in annotate with objdump so that it can fallback to another
> method when failing. But it'd require more changes beyond
> this work and I'm not sure if it's really worth it.
Right, I think we shouldn't delay processing these patches because of
that, we can do it as follow up patches, both for fallbacks in case we
can detect problems like we did with capstone -> objdump disasm and also
to be able to compare outputs in 'perf test' shell scripts, discounting
known/expected minor differences.
- Arnaldo
next prev parent reply other threads:[~2024-05-29 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 18:22 [PATCH v7 1/4] perf report: Support LLVM for addr2line() Steinar H. Gunderson
2024-05-26 18:22 ` [PATCH v7 2/4] perf annotate: split out read_symbol() Steinar H. Gunderson
2024-05-26 18:22 ` [PATCH v7 3/4] perf annotate: LLVM-based disassembler Steinar H. Gunderson
2024-05-29 4:06 ` Namhyung Kim
2024-06-02 20:38 ` Steinar H. Gunderson
2024-05-26 18:22 ` [PATCH v7 4/4] perf report: LLVM-based symbol listing Steinar H. Gunderson
2024-05-26 21:24 ` Steinar H. Gunderson
2024-05-29 4:11 ` Namhyung Kim
2024-06-02 20:39 ` Steinar H. Gunderson
2024-05-29 3:56 ` [PATCH v7 1/4] perf report: Support LLVM for addr2line() Namhyung Kim
2024-05-29 13:52 ` Arnaldo Carvalho de Melo [this message]
2024-05-30 16:55 ` Namhyung Kim
2024-05-30 16:58 ` Namhyung Kim
2024-06-02 20:37 ` Steinar H. Gunderson
2024-06-05 1:13 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlczO4D8J1lgWBZj@x1 \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sesse@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox