From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: mchehab@kernel.org, ming.qian@nxp.com, eagle.zhou@nxp.com,
digetx@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'
Date: Thu, 30 May 2024 13:27:40 +0000 [thread overview]
Message-ID: <Zlh-zGV7U5rheUbY@gallifrey> (raw)
In-Reply-To: <4496bc6e-e5c0-4f86-b9c1-37ad2d2b687d@xs4all.nl>
* Hans Verkuil (hverkuil@xs4all.nl) wrote:
> On 25/05/2024 02:01, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'tegra_vde_h264_frame' has been unused since
> > commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> > support").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > index cfea5572a1b8..d8812fc06c67 100644
> > --- a/drivers/media/platform/nvidia/tegra-vde/h264.c
> > +++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > @@ -19,11 +19,6 @@
> > #define FLAG_B_FRAME 0x1
> > #define FLAG_REFERENCE 0x2
> >
> > -struct tegra_vde_h264_frame {
> > - unsigned int frame_num;
> > - unsigned int flags;
> > -};
> > -
> > struct tegra_vde_h264_decoder_ctx {
> > unsigned int dpb_frames_nb;
> > unsigned int dpb_ref_frames_with_earlier_poc_nb;
>
> There is one more reference to this, that also can be dropped:
>
> $ git grep tegra_vde_h264_frame
> drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;
Thanks! v2 just sent (where I also fixed a typo in the first patch
in the series's title).
Dave
> Regards,
>
> Hans
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
prev parent reply other threads:[~2024-05-30 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 0:01 [PATCH 0/3] Dead structs in media/platform linux
2024-05-25 0:01 ` [PATCH 1/3] meida: amphion: remove unused struct 'vpu_malone_frame_buffer' linux
2024-05-25 0:01 ` [PATCH 2/3] media: m2m-deinterlace: remove unused struct 'vb2_dc_conf' linux
2024-05-25 0:01 ` [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame' linux
2024-05-30 12:26 ` Hans Verkuil
2024-05-30 13:27 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zlh-zGV7U5rheUbY@gallifrey \
--to=linux@treblig.org \
--cc=digetx@gmail.com \
--cc=eagle.zhou@nxp.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox