* [PATCH] iommu/vt-d: Fix panic accessing amd_iommu_enable_faulting
@ 2024-05-30 12:57 Dimitri Sivanich
2024-05-30 15:17 ` Vasant Hegde
0 siblings, 1 reply; 2+ messages in thread
From: Dimitri Sivanich @ 2024-05-30 12:57 UTC (permalink / raw)
To: Yi Zhang, Tian, Kevin, Vasant Hegde, Baolu Lu, Joerg Roedel,
Suravee Suthikulpanit, Will Deacon, Robin Murphy, David Wang,
Shinichiro Kawasaki, Dimitri Sivanich, iommu
Cc: linux-kernel, Steve Wahl, Russ Anderson
This fixes a bug introduced by commit d74169ceb0d2 ("iommu/vt-d: Allocate
DMAR fault interrupts locally"). The panic happens when
amd_iommu_enable_faulting is called from CPUHP_AP_ONLINE_DYN context.
Signed-off-by: Dimitri Sivanich <sivanich@hpe.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
---
drivers/iommu/amd/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index a18e74878f68..b02b959d12af 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -3353,7 +3353,7 @@ int amd_iommu_reenable(int mode)
return 0;
}
-int __init amd_iommu_enable_faulting(unsigned int cpu)
+int amd_iommu_enable_faulting(unsigned int cpu)
{
/* We enable MSI later when PCI is initialized */
return 0;
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu/vt-d: Fix panic accessing amd_iommu_enable_faulting
2024-05-30 12:57 [PATCH] iommu/vt-d: Fix panic accessing amd_iommu_enable_faulting Dimitri Sivanich
@ 2024-05-30 15:17 ` Vasant Hegde
0 siblings, 0 replies; 2+ messages in thread
From: Vasant Hegde @ 2024-05-30 15:17 UTC (permalink / raw)
To: Dimitri Sivanich, Yi Zhang, Tian, Kevin, Baolu Lu, Joerg Roedel,
Suravee Suthikulpanit, Will Deacon, Robin Murphy, David Wang,
Shinichiro Kawasaki, iommu
Cc: linux-kernel, Steve Wahl, Russ Anderson
Hi Dimitri,
On 5/30/2024 6:27 PM, Dimitri Sivanich wrote:
> This fixes a bug introduced by commit d74169ceb0d2 ("iommu/vt-d: Allocate
> DMAR fault interrupts locally"). The panic happens when
> amd_iommu_enable_faulting is called from CPUHP_AP_ONLINE_DYN context.
Issue is happening on AMD system. Can you please change subject line. s/vt-d/amd/ ?
Also may be add "Fixes" tag as well.
-Vasant
>
> Signed-off-by: Dimitri Sivanich <sivanich@hpe.com>
> Tested-by: Yi Zhang <yi.zhang@redhat.com>
> ---
> drivers/iommu/amd/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index a18e74878f68..b02b959d12af 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -3353,7 +3353,7 @@ int amd_iommu_reenable(int mode)
> return 0;
> }
>
> -int __init amd_iommu_enable_faulting(unsigned int cpu)
> +int amd_iommu_enable_faulting(unsigned int cpu)
> {
> /* We enable MSI later when PCI is initialized */
> return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-30 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 12:57 [PATCH] iommu/vt-d: Fix panic accessing amd_iommu_enable_faulting Dimitri Sivanich
2024-05-30 15:17 ` Vasant Hegde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox