From: Petr Mladek <pmladek@suse.com>
To: Sreenath Vijayan <sreenath.vijayan@sony.com>
Cc: john.ogness@linutronix.de, gregkh@linuxfoundation.org,
jirislaby@kernel.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
taichi.shimoyashiki@sony.com, daniel.palmer@sony.com,
anandakumar.balasubramaniam@sony.com
Subject: Re: [PATCH] printk: Rename console_replay_all() and update context
Date: Fri, 31 May 2024 10:49:05 +0200 [thread overview]
Message-ID: <ZlmPAZUeKIDFKLdf@pathway.suse.cz> (raw)
In-Reply-To: <66582edb.650a0220.8de7.c591SMTPIN_ADDED_BROKEN@mx.google.com>
On Thu 2024-05-30 13:15:47, Sreenath Vijayan wrote:
> Rename console_replay_all() to console_try_replay_all() to make
> clear that the implementation is best effort. Also, the function
> should not be called in NMI context as it takes locks, so update
> the comment in code.
>
> Fixes: 693f75b91a91 ("printk: Add function to replay kernel log on consoles")
> Fixes: 1b743485e27f ("tty/sysrq: Replay kernel log messages on consoles via sysrq")
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Shimoyashiki Taichi <taichi.shimoyashiki@sony.com>
> Signed-off-by: Sreenath Vijayan <sreenath.vijayan@sony.com>
Thanks for the fix.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
PS: I am going to queue it for 6.11. It is not critical
to hurry it into 6.10-rcX.
next parent reply other threads:[~2024-05-31 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <66582edb.650a0220.8de7.c591SMTPIN_ADDED_BROKEN@mx.google.com>
2024-05-31 8:49 ` Petr Mladek [this message]
2024-06-04 8:09 ` [PATCH] printk: Rename console_replay_all() and update context Petr Mladek
2024-06-06 6:50 ` Sreenath Vijayan
2024-05-30 7:45 Sreenath Vijayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlmPAZUeKIDFKLdf@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=anandakumar.balasubramaniam@sony.com \
--cc=daniel.palmer@sony.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sreenath.vijayan@sony.com \
--cc=taichi.shimoyashiki@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox