Re: [PATCH] auxdisplay: linedisp: Support configuring the boot message

Andy Shevchenko
2024-05-31T08:16:53Z

On Fri, May 31, 2024 at 10:45 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, May 31, 2024 at 7:28 AM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> > Like we do for charlcd, allow the configuration of the initial message
> > on line-display devices.

...

> > +#ifndef CONFIG_PANEL_BOOT_MESSAGE
> > #include <generated/utsrelease.h>
> > +#endif
>
> The #ifndef/#endif is not really needed.

It's needed to avoid unnecessary build of the module (in case of m).

> As I see no real deficiencies:
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

I believe you agree with leaving ifdeffery above.