Re: [PATCH v2] staging: iio: adt7316: remove unused struct 'adt7316_limit_regs'

Dr. David Alan Gilbert
2024-06-01T20:51:02Z

* Jonathan Cameron (jic23@kernel.org) wrote:
> On Thu, 30 May 2024 11:45:03 +0200
> Greg KH <greg@kroah.com> wrote:
>
> > On Wed, May 29, 2024 at 05:00:55PM +0100, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > >
> > > 'adt7316_limit_regs' has never been used since the original
> > > commit 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9
> > > driver").
> > >
> > > The comment above it is a copy-and-paste from a different struct.
> > >
> > > Remove both the struct and the comment.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> Greg's bot is correct, but meh, not worth a v3.
>
> I picked up Nuno's tag from v1 though. I don't think that came
> in after you'd sent this, so I guess you missed that one.
>
> Applied.

Thanks!

Dave

> Jonathan
>
> > > ---
> > > drivers/staging/iio/addac/adt7316.c | 9 ---------
> > > 1 file changed, 9 deletions(-)
> > >
> > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> > > index 79467f056a05..f4260786d50a 100644
> > > --- a/drivers/staging/iio/addac/adt7316.c
> > > +++ b/drivers/staging/iio/addac/adt7316.c
> > > @@ -209,15 +209,6 @@ struct adt7316_chip_info {
> > > #define ADT7316_TEMP_AIN_INT_MASK \
> > > (ADT7316_TEMP_INT_MASK)
> > >
> > > -/*
> > > - * struct adt7316_chip_info - chip specific information
> > > - */
> > > -
> > > -struct adt7316_limit_regs {
> > > - u16 data_high;
> > > - u16 data_low;
> > > -};
> > > -
> > > static ssize_t adt7316_show_enabled(struct device *dev,
> > > struct device_attribute *attr,
> > > char *buf)
> > > --
> > > 2.45.1
> > >
> > >
> >
> > Hi,
> >
> > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> > a patch that has triggered this response. He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created. Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> >
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> >
> > - This looks like a new version of a previously submitted patch, but you
> > did not list below the --- line any changes from the previous version.
> > Please read the section entitled "The canonical patch format" in the
> > kernel file, Documentation/process/submitting-patches.rst for what
> > needs to be done here to properly describe this.
> >
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> >
> > thanks,
> >
> > greg k-h's patch email bot
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/