From: "Steinar H. Gunderson" <sesse@google.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: acme@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, irogers@google.com
Subject: Re: [PATCH v7 3/4] perf annotate: LLVM-based disassembler
Date: Sun, 2 Jun 2024 22:38:42 +0200 [thread overview]
Message-ID: <ZlzYUjBJzlERP37P@google.com> (raw)
In-Reply-To: <CAM9d7cgyBGPc-HCC9nk_xNiVi3LZGM1-dE5OR4FxRvNWoFZFDA@mail.gmail.com>
On Tue, May 28, 2024 at 09:06:24PM -0700, Namhyung Kim wrote:
>> + struct symbol_lookup_storage *storage =
>> + (struct symbol_lookup_storage *)disinfo;
> You don't need this in C. :) Also we usually put a blank line
> after declaration (at least, at the beginning).
Done.
> We put the arguments at the same line and align them.
> Please do the same in other places.
Done, I believe.
>> + LLVMDisasmDispose(disasm);
>> + free(buf);
>> + free(line_storage);
>> + return 0;
> Often we just set a different return value here and share the
> error handling logic at the end.
Done.
/* Steinar */
next prev parent reply other threads:[~2024-06-02 20:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 18:22 [PATCH v7 1/4] perf report: Support LLVM for addr2line() Steinar H. Gunderson
2024-05-26 18:22 ` [PATCH v7 2/4] perf annotate: split out read_symbol() Steinar H. Gunderson
2024-05-26 18:22 ` [PATCH v7 3/4] perf annotate: LLVM-based disassembler Steinar H. Gunderson
2024-05-29 4:06 ` Namhyung Kim
2024-06-02 20:38 ` Steinar H. Gunderson [this message]
2024-05-26 18:22 ` [PATCH v7 4/4] perf report: LLVM-based symbol listing Steinar H. Gunderson
2024-05-26 21:24 ` Steinar H. Gunderson
2024-05-29 4:11 ` Namhyung Kim
2024-06-02 20:39 ` Steinar H. Gunderson
2024-05-29 3:56 ` [PATCH v7 1/4] perf report: Support LLVM for addr2line() Namhyung Kim
2024-05-29 13:52 ` Arnaldo Carvalho de Melo
2024-05-30 16:55 ` Namhyung Kim
2024-05-30 16:58 ` Namhyung Kim
2024-06-02 20:37 ` Steinar H. Gunderson
2024-06-05 1:13 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlzYUjBJzlERP37P@google.com \
--to=sesse@google.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox