public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Alistair Francis <alistair23@gmail.com>,
	bhelgaas@google.com, linux-pci@vger.kernel.org,
	alex.williamson@redhat.com, christian.koenig@amd.com,
	kch@nvidia.com, gregkh@linuxfoundation.org, logang@deltatee.com,
	linux-kernel@vger.kernel.org, chaitanyak@nvidia.com,
	rdunlap@infradead.org,
	Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v10 3/4] PCI/DOE: Expose the DOE features via sysfs
Date: Sat, 15 Jun 2024 15:12:55 +0200	[thread overview]
Message-ID: <Zm2TVxvMaD7ogNfK@wunner.de> (raw)
In-Reply-To: <20240523122448.0000799f@Huawei.com>

On Thu, May 23, 2024 at 12:24:48PM +0100, Jonathan Cameron wrote:
> What happens if multiple DOE which support the same protocol?
> (IIRC that's allowed).  You probably need to paper over repeat
> sysfs attributes and make sure they don't get double freed etc.

So I believe this was fixed in v11 but assuming the point here is
to allow lspci to display supported protocols without speaking DOE
with the device, the way it's implemented now user space cannot
discern which mailbox supports which protocol.  Or if multiple
mailboxes support the same protocol.  I'm wondering in how far
that limits the usefulness of the feature.

sysfs doesn't support nested groups.  But we could dynamically
create one attribute group per mailbox.  Or have one file per
mailbox in a common doe_features group, each file containing
all the supported protocols. Hm...

Thanks,

Lukas

  parent reply	other threads:[~2024-06-15 13:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 10:11 [PATCH v10 1/4] PCI/DOE: Rename DOE protocol to feature Alistair Francis
2024-05-22 10:11 ` [PATCH v10 2/4] PCI/DOE: Rename Discovery Response Data Object Contents to type Alistair Francis
2024-05-23 11:02   ` Jonathan Cameron
2024-05-22 10:11 ` [PATCH v10 3/4] PCI/DOE: Expose the DOE features via sysfs Alistair Francis
2024-05-23 11:24   ` Jonathan Cameron
2024-06-07  5:29     ` Alistair Francis
2024-06-15 13:12     ` Lukas Wunner [this message]
2024-05-23 15:26   ` kernel test robot
2024-05-22 10:11 ` [PATCH v10 4/4] PCI/DOE: Allow enabling DOE without CXL Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zm2TVxvMaD7ogNfK@wunner.de \
    --to=lukas@wunner.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alex.williamson@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=chaitanyak@nvidia.com \
    --cc=christian.koenig@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox