From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] spi: gpio: Make num_chipselect 8-bit in the struct spi_gpio_platform_data
Date: Thu, 6 Jun 2024 00:09:24 +0300 [thread overview]
Message-ID: <ZmDUBHUyy1uozcn2@smile.fi.intel.com> (raw)
In-Reply-To: <ZksXrM-W_69e5q2m@smile.fi.intel.com>
On Mon, May 20, 2024 at 12:28:12PM +0300, Andy Shevchenko wrote:
> On Fri, May 17, 2024 at 10:55:55PM +0100, Mark Brown wrote:
> > On Fri, May 17, 2024 at 10:42:03PM +0300, Andy Shevchenko wrote:
> > > There is no use for whole 16-bit for the number of chip select pins.
> > > Drop it to 8 bits.
> >
> > because...?
>
> To make the type stricter, but since there is no other benefits and
> this one likely won't help to catch the (incorrect) use of big numbers
> I think we don't need it.
>
> > It's the only field in the struct so it's not like it makes
> > any meaningful different to struct layout.
Should I do something about the first two patches or is it fine to get them in?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-06-05 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 19:42 [PATCH v1 0/3] spi: gpio: Convert to be used outside of OF Andy Shevchenko
2024-05-17 19:42 ` [PATCH v1 1/3] spi: gpio: Make use of device properties Andy Shevchenko
2024-05-17 19:42 ` [PATCH v1 2/3] spi: gpio: Use traditional pattern when checking error codes Andy Shevchenko
2024-05-17 19:42 ` [PATCH v1 3/3] spi: gpio: Make num_chipselect 8-bit in the struct spi_gpio_platform_data Andy Shevchenko
2024-05-17 21:55 ` Mark Brown
2024-05-20 9:28 ` Andy Shevchenko
2024-06-05 21:09 ` Andy Shevchenko [this message]
2024-06-05 21:22 ` Mark Brown
2024-06-06 10:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmDUBHUyy1uozcn2@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox