From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chia-I Wu <olvaffe@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Baoquan He <bhe@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] resource: add a simple test for walk_iomem_res_desc()
Date: Thu, 6 Jun 2024 13:04:39 +0300 [thread overview]
Message-ID: <ZmGJt1I4Glvq_Myz@smile.fi.intel.com> (raw)
In-Reply-To: <20240606004002.3280960-1-olvaffe@gmail.com>
On Wed, Jun 05, 2024 at 05:39:48PM -0700, Chia-I Wu wrote:
> This mainly tests that find_next_iomem_res() does not miss resources.
Read Submitting Patches documentation on imperative mood and modify the commit
message to follow.
...
> + /* build the resource tree under the test root:
> + *
> + * 0x0000-0x0fff: res[0], a match
> + * 0x1000-0x1fff: res[1], a non-match
> + * 0x2000-0x2fff: a hole
> + * 0x3000-0x3fff: res[2], a non-match
> + * 0x3800-0x3bff: res[3], a match
> + * 0x4000-0x4fff: res[4], a match
> + */
/*
* This is good, but multi-line comment
* style is broken along with English grammar, i.e.
* do not forget that sentences are started with
* a capital letter.
*/
...
Please, do not send a new version this week. Take your time.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-06-06 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 0:39 [PATCH v5] resource: add a simple test for walk_iomem_res_desc() Chia-I Wu
2024-06-06 0:46 ` Chia-I Wu
2024-06-06 10:01 ` Andy Shevchenko
2024-06-06 10:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmGJt1I4Glvq_Myz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alison.schofield@intel.com \
--cc=bhe@redhat.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olvaffe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox