From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Stefan Berger <stefanb@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ecdsa: Fix the public key format description
Date: Fri, 7 Jun 2024 19:53:33 +0800 [thread overview]
Message-ID: <ZmL0vciwMYCEQeIT@gondor.apana.org.au> (raw)
In-Reply-To: <20240527202840.4818-1-jarkko@kernel.org>
On Mon, May 27, 2024 at 11:28:39PM +0300, Jarkko Sakkinen wrote:
> Public key blob is not just x and y concatenated. It follows RFC5480
> section 2.2. Address this by re-documenting the function with the
> correct description of the format.
>
> Link: https://datatracker.ietf.org/doc/html/rfc5480
> Fixes: 4e6602916bc6 ("crypto: ecdsa - Add support for ECDSA signature verification")
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
> It is a bug fix that does not really need a stable backport. Still
> categorizes as a bug because by following the existing documentation
> you end up with an error code.
> crypto/ecdsa.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-06-07 11:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 20:28 [PATCH] crypto: ecdsa: Fix the public key format description Jarkko Sakkinen
2024-05-27 21:05 ` Jarkko Sakkinen
2024-05-27 21:58 ` Jarkko Sakkinen
2024-05-27 22:18 ` Jarkko Sakkinen
2024-05-27 22:31 ` Jarkko Sakkinen
2024-05-27 22:49 ` Jarkko Sakkinen
2024-05-27 22:59 ` Jarkko Sakkinen
2024-05-28 12:37 ` Stefan Berger
2024-05-28 13:18 ` Jarkko Sakkinen
2024-05-28 13:26 ` Jarkko Sakkinen
2024-05-28 13:29 ` Jarkko Sakkinen
2024-05-28 11:18 ` Stefan Berger
2024-05-28 11:43 ` Jarkko Sakkinen
2024-06-07 11:53 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmL0vciwMYCEQeIT@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jarkko@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox