Re: [PATCH v4 5/7] crash_dump: retrieve dm crypt keys in kdump kernel

Coiby Xu
2024-06-07T12:28:41Z

On Fri, Jun 07, 2024 at 05:50:15PM +0800, Baoquan He wrote:
>On 05/23/24 at 01:04pm, Coiby Xu wrote:
>......
>> +ssize_t __weak dm_crypt_keys_read(char *buf, size_t count, u64 *ppos)
>> +{
>> + struct kvec kvec = { .iov_base = buf, .iov_len = count };
>> + struct iov_iter iter;
>> +
>> + iov_iter_kvec(&iter, READ, &kvec, 1, count);
>> + return read_from_oldmem(&iter, count, ppos, false);
>Do we need create a x86 specific version to cope with the confidential
>computing thing, e.g sme/tdx?

Thanks for raising the concern! I'll test sme/tdx and will fix it in v6
if any issue is found.

--
Best regards,
Coiby