From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: linux-input@vger.kernel.org, vi@endrift.com,
maxwell.nguyen@hp.com, appsforartists@google.com, carl.ng@hp.com,
christophe.jaillet@wanadoo.fr, matt.git@fastmail.fm,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - add support for ASUS ROG RAIKIRI PRO
Date: Fri, 7 Jun 2024 16:41:12 -0700 [thread overview]
Message-ID: <ZmOamChB69DuXWPn@google.com> (raw)
In-Reply-To: <20240607223722.1170776-1-luke@ljones.dev>
Hi Luke,
On Sat, Jun 08, 2024 at 10:37:22AM +1200, Luke D. Jones wrote:
> Add the VID/PID for ASUS ROG RAIKIRI PRO to
> xpad_device and the VID to xpad_table.
>
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
> drivers/hid/hid-ids.h | 1 +
> drivers/input/joystick/xpad.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 61d2a21affa2..31c522fa4e87 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -209,6 +209,7 @@
> #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD2 0x19b6
> #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_KEYBOARD3 0x1a30
> #define USB_DEVICE_ID_ASUSTEK_ROG_Z13_LIGHTBAR 0x18c6
> +#define USB_DEVICE_ID_ASUSTEK_ROG_RAIKIRI_PAD 0x1abb
> #define USB_DEVICE_ID_ASUSTEK_ROG_NKEY_ALLY 0x1abe
> #define USB_DEVICE_ID_ASUSTEK_ROG_CLAYMORE_II_KEYBOARD 0x196b
> #define USB_DEVICE_ID_ASUSTEK_FX503VD_KEYBOARD 0x1869
This chunk is not needed, I dropped it and applied the rest.
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6fadaddb2b90..3a5af0909233 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -209,6 +209,7 @@ static const struct xpad_device {
> { 0x0738, 0xf738, "Super SFIV FightStick TE S", 0, XTYPE_XBOX360 },
> { 0x07ff, 0xffff, "Mad Catz GamePad", 0, XTYPE_XBOX360 },
> { 0x0b05, 0x1a38, "ASUS ROG RAIKIRI", 0, XTYPE_XBOXONE },
> + { 0x0b05, 0x1abb, "ASUS ROG RAIKIRI PRO", 0, XTYPE_XBOXONE },
> { 0x0c12, 0x0005, "Intec wireless", 0, XTYPE_XBOX },
> { 0x0c12, 0x8801, "Nyko Xbox Controller", 0, XTYPE_XBOX },
> { 0x0c12, 0x8802, "Zeroplus Xbox Controller", 0, XTYPE_XBOX },
> --
> 2.45.2
>
Thanks.
--
Dmitry
prev parent reply other threads:[~2024-06-07 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 22:37 [PATCH] Input: xpad - add support for ASUS ROG RAIKIRI PRO Luke D. Jones
2024-06-07 23:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmOamChB69DuXWPn@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=appsforartists@google.com \
--cc=carl.ng@hp.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=matt.git@fastmail.fm \
--cc=maxwell.nguyen@hp.com \
--cc=vi@endrift.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox