From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Erick Archer <erick.archer@outlook.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Vicki Pfau" <vi@endrift.com>,
"Brenton Simpson" <appsforartists@google.com>,
"Max Nguyen" <maxwell.nguyen@hp.com>, "Carl Ng" <carl.ng@hp.com>,
"Matt Scialabba" <matt.git@fastmail.fm>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Kees Cook" <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Justin Stitt" <justinstitt@google.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] Input: joystick - use sizeof(*pointer) instead of sizeof(type)
Date: Sun, 9 Jun 2024 14:41:16 -0700 [thread overview]
Message-ID: <ZmYhfNmyjX6OiJP4@google.com> (raw)
In-Reply-To: <AS8PR02MB7237FEA55FAC8A9453F2DA6F8BC42@AS8PR02MB7237.eurprd02.prod.outlook.com>
On Sat, Jun 08, 2024 at 05:13:57PM +0200, Erick Archer wrote:
> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter).
>
> At the same time refactor the code to not use assignment in "if"
> conditions.
>
> This patch has no effect on runtime behavior.
>
> Signed-off-by: Erick Archer <erick.archer@outlook.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2024-06-09 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 15:13 [PATCH] Input: joystick - use sizeof(*pointer) instead of sizeof(type) Erick Archer
2024-06-09 21:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmYhfNmyjX6OiJP4@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=appsforartists@google.com \
--cc=carl.ng@hp.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=erick.archer@outlook.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.git@fastmail.fm \
--cc=maxwell.nguyen@hp.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vi@endrift.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox