From: "<Tree Davies" <tdavies@darkphysics.net>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Tree Davies <tdavies@darkphysics.net>,
gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
anjan@momi.ca, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz
Date: Mon, 10 Jun 2024 19:15:51 -0700 [thread overview]
Message-ID: <ZmezV4UvCEImxMBX@lunchbox.darkphysics> (raw)
In-Reply-To: <5ccfa433-f1be-45f6-9138-348cb4093866@moroto.mountain>
On Mon, Jun 10, 2024 at 09:08:03AM +0300, Dan Carpenter wrote:
> On Sun, Jun 09, 2024 at 10:44:34PM -0700, Tree Davies wrote:
> > Rename variable bforced_tx20Mhz to forced_tx_20mhz
> > to fix checkpatch warning Avoid CamelCase.
>
> The correct capitalization for megahertz is MHz. So the original is
> wrong but the new name is not correct either.
>
> regards,
> dan carpenter
>
Thanks Dan,
So... I guess just spell it out as 'forced_tx_20_megahertz' ?
Tree
next prev parent reply other threads:[~2024-06-11 2:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 5:44 [PATCH 00/24] Staging: rtl8192e: Maintenance renames and cleanup Tree Davies
2024-06-10 5:44 ` [PATCH 01/24] Staging: rtl8192e: Rename variable bHwSec Tree Davies
2024-06-10 5:44 ` [PATCH 02/24] Staging: rtl8192e: Rename variable bIsMulticast Tree Davies
2024-06-10 5:44 ` [PATCH 03/24] Staging: rtl8192e: Rename variable HTCurrentOperaRate Tree Davies
2024-06-10 5:44 ` [PATCH 04/24] Staging: rtl8192e: Rename variable HTOpMode Tree Davies
2024-06-10 5:44 ` [PATCH 05/24] Staging: rtl8192e: Rename variable bRTSEnable Tree Davies
2024-06-10 5:44 ` [PATCH 06/24] Staging: rtl8192e: Rename variable bRTSBW Tree Davies
2024-06-10 5:44 ` [PATCH 07/24] Staging: rtl8192e: Rename variable bCTSEnable Tree Davies
2024-06-10 5:44 ` [PATCH 08/24] Staging: rtl8192e: Rename variable bRTSUseShortGI Tree Davies
2024-06-10 5:44 ` [PATCH 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz Tree Davies
2024-06-10 6:08 ` Dan Carpenter
2024-06-11 2:15 ` <Tree Davies [this message]
2024-06-11 5:18 ` Dan Carpenter
2024-06-10 5:44 ` [PATCH 10/24] Staging: rtl8192e: Rename variable bPacketBW Tree Davies
2024-06-10 5:44 ` [PATCH 11/24] Staging: rtl8192e: Rename variable bBroadcast Tree Davies
2024-06-10 5:44 ` [PATCH 12/24] Staging: rtl8192e: Rename variable CntAfterLink Tree Davies
2024-06-10 5:44 ` [PATCH 13/24] Staging: rtl8192e: Rename variable bUseShortGI Tree Davies
2024-06-10 5:44 ` [PATCH 14/24] Staging: rtl8192e: Rename function TsStartAddBaProcess() Tree Davies
2024-06-10 5:44 ` [PATCH 15/24] Staging: rtl8192e: Fix spaces/tab alignment to match open parenthesis Tree Davies
2024-06-10 5:44 ` [PATCH 16/24] Staging: rtl8192e: Rename function rtllib_query_BandwidthMode Tree Davies
2024-06-10 5:44 ` [PATCH 17/24] Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode Tree Davies
2024-06-10 5:44 ` [PATCH 18/24] Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI Tree Davies
2024-06-10 5:44 ` [PATCH 19/24] Staging: rtl8192e: Rename variable bUseShortPreamble Tree Davies
2024-06-10 5:44 ` [PATCH 20/24] Staging: rtl8192e: Rename variable bRTSSTBC Tree Davies
2024-06-10 5:44 ` [PATCH 21/24] Remove parameter bIsAmsdu from rtllib_classify() Tree Davies
2024-06-10 5:44 ` [PATCH 22/24] Remove variable IsAmsdu from rtllib_xmit_inter() Tree Davies
2024-06-10 5:44 ` [PATCH 23/24] Fix space/tab alignment to match open parenthesis in rtllib_tx.c Tree Davies
2024-06-10 5:44 ` [PATCH 24/24] Fix space/tab alignment to match open parenthesis in rtllib_rx.c Tree Davies
2024-06-10 6:25 ` [PATCH 00/24] Staging: rtl8192e: Maintenance renames and cleanup Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmezV4UvCEImxMBX@lunchbox.darkphysics \
--to=tdavies@darkphysics.net \
--cc=anjan@momi.ca \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox