Re: [PATCH v5 02/18] mm: Define __pte_leaf_size() to also take a PMD entry

Peter Xu
2024-06-11T21:43:50Z

On Tue, Jun 11, 2024 at 07:00:14PM +0000, LEROY Christophe wrote:
> But what about something like
>
> static inline pte_t pmd_pte(pmd_t pmd)
> {
> return *(pte_t *)pmd_page_vaddr(pmd);
> }
>
> Would it do the trick ?
>
> Of course it would require to carefully make sure all accesses are done
> through pmd_pte().
>
> Would that work ?

Looks possible to me. It's just that we may miss some spots, and it can
hide in the details.

I'm looking at Power's pmd_access_permitted() right below pmd_write(),
which indeed uses pmd_pte() already. However before that there's also the
other call to pmd_is_serializing(), which doesn't look alright to work on
pgtable pages.. In this case maybe it's easy, as I assume pgtable page is
stable. Didn't further look, though.

Said that, this doesn't look like a blocker. So maybe worth trying if we're
careful and with some good testing coverages.

Thanks,

--
Peter Xu