From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Danilo Krummrich <dakr@redhat.com>
Cc: daniel@ffwll.ch, nouveau@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kherbst@redhat.com, lyude@redhat.com
Subject: Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'
Date: Tue, 11 Jun 2024 10:37:38 +0000 [thread overview]
Message-ID: <Zmgo8leSWpsjVVBS@gallifrey> (raw)
In-Reply-To: <de79f41d-3a9b-4f15-b270-246af8b4c5b0@redhat.com>
* Danilo Krummrich (dakr@redhat.com) wrote:
> On 5/18/24 01:26, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'init_exec' is unused since
> > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
> > init table parser")
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Acked-by: Danilo Krummrich <dakr@redhat.com>
>
> To which series does this patch belong?
Actually all of them were independent patches on drm
some of which are all in, so it can be taken by itself.
> Need me to apply it?
Yes please!
Thanks,
Dave
> - Danilo
>
> > ---
> > drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> > index 79cfab53f80e..8c3c1f1e01c5 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> > @@ -43,11 +43,6 @@
> > #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
> > #define LOG_OLD_VALUE(x)
> > -struct init_exec {
> > - bool execute;
> > - bool repeat;
> > -};
> > -
> > static bool nv_cksum(const uint8_t *data, unsigned int length)
> > {
> > /*
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-06-11 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 23:26 [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec' linux
2024-06-03 17:30 ` Dr. David Alan Gilbert
2024-06-11 10:02 ` Danilo Krummrich
2024-06-11 10:37 ` Dr. David Alan Gilbert [this message]
2024-06-11 21:24 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmgo8leSWpsjVVBS@gallifrey \
--to=linux@treblig.org \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox